Review main Merged

79565[TASK] SchemaMigrator is stateless

Christian Kuhn CR +2 V +2 Easy +17 −21 updated 06/30/23, 10:14

Commit message

Class SchemaMigrator has an unused property $schema.
Removing this property makes it more obvious
this service is stateless.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Christian Kuhn uploaded patch set 1 06/30/23, 08:16

  2. Christian Kuhn rebased onto patch set 2 06/30/23, 08:17

  3. core-ci voted on patch set 2 V +1 06/30/23, 08:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43136

  4. core-ci voted on patch set 1 V +1 06/30/23, 08:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43135

  5. Benni Mack voted on patch set 2 V +1 CR +1 06/30/23, 09:46

  6. Oliver Klee voted on patch set 2 V +1 CR +1 06/30/23, 10:14

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 06/30/23, 10:14

  8. Christian Kuhn merged patch set 3 06/30/23, 10:14