79569[BUGFIX] Allow integer keys in ArrayUtility::flatten()
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 2
Review log 1622
-
Stephan Großberndt uploaded patch set 1 06/30/23, 09:18
-
core-ci voted on patch set 1 V -1 06/30/23, 09:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43140
-
Stephan Großberndt uploaded patch set 2
V -106/30/23, 09:42 -
Benni Mack updated the commit message in patch set 3 06/30/23, 09:44
-
Benni Mack voted on patch set 3 V +1 CR +1 06/30/23, 09:44
-
core-ci voted on patch set 2 V -1 06/30/23, 09:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43142
-
Christian Kuhn commented on patch set 3 CR -1 06/30/23, 09:52
will fix test -
core-ci voted on patch set 3 V -1 06/30/23, 09:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43143
-
Stephan Großberndt updated the commit message in patch set 4
CR +1V +106/30/23, 09:55 -
Stephan Großberndt commented on patch set 4 06/30/23, 09:56
Reply
Ah, sorry, I need to supply two equal arrays, right? -
Christian Kuhn uploaded patch set 5 06/30/23, 09:57
-
Christian Kuhn commented on patch set 5 06/30/23, 09:59
Reply
yeah. and the test was added to flattenPlain, not to flatten DP ;) now the test fails as expected when the code change is reverted, and is green when the code change is applied. -
Stephan Großberndt commented on patch set 5 06/30/23, 09:59
Reply
thanks! -
Christian Kuhn updated the commit message in patch set 6 06/30/23, 10:03
-
core-ci voted on patch set 4 V -1 06/30/23, 10:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43145
-
core-ci voted on patch set 5 V +1 06/30/23, 10:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43146
-
Oliver Klee commented on patch set 6 V +1 CR +1 06/30/23, 10:09
Should we backport this to 11.5 as well? -
Stephan Großberndt commented on patch set 6 06/30/23, 10:10
Reply
Done. Not necessary there as only v12 has strict_types=1 for ArrayUtility https://review.typo3.org/c/Packages/TYPO3.CMS/+/73984 -
Christian Kuhn commented on patch set 6 V +1 CR +1 06/30/23, 10:10
Reply
no: the issue was triggered by the related patch, which went to v12 and up, only. See coredev chat with Stephan and me on this. -
core-ci voted on patch set 6 V +1 06/30/23, 10:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43147
-
Benni Mack voted on patch set 6 V +2 CR +2 06/30/23, 10:15
-
Benni Mack merged patch set 7 06/30/23, 10:16