Review main Merged

79579[TASK] Remove useless test in GeneralUtilityTest

Torben Hansen CR +2 V +2 Easy +0 −14 updated 07/02/23, 09:10

Commit message

This change removes a useless test, which only tests PHP
native `htmlspecialchars()` and `htmlspecialchars_decode()`
functionality.

The test did previously test `GU:htmlspecialchars_decode()`,
which has replaced by PHP native `htmlspecialchars_decode()`
in #54777.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 810

  1. Torben Hansen uploaded patch set 1 07/01/23, 13:28

  2. core-ci voted on patch set 1 V +1 07/01/23, 13:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43182

  3. Oliver Klee voted on patch set 1 V +1 CR +1 07/01/23, 14:22

  4. Oli Bartsch commented on patch set 1 07/01/23, 16:05

    Should we backport this to v12?
  5. Torben Hansen updated the commit message in patch set 2 CR +1 V +1 07/02/23, 08:47

  6. Torben Hansen commented on patch set 2 07/02/23, 08:48

    Reply

    Yes, I'll update the commit message.
  7. Oliver Klee voted on patch set 2 V +1 CR +1 07/02/23, 08:52

  8. core-ci voted on patch set 2 V +1 07/02/23, 08:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43188

  9. Oli Bartsch voted on patch set 2 V +2 CR +2 07/02/23, 09:10

  10. Oli Bartsch merged patch set 3 07/02/23, 09:10