Review main Merged

79583[TASK] Streamline error for already filled database

Jochen Roth CR +2 V +2 Easy +8 −1 updated 07/06/23, 19:57

Commit message

Currently, when the selected db has already tables
an exception is thrown

This has been changed by showing a nicely formatted
error message like done for any other error in this command.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1013

  1. Jochen Roth uploaded patch set 1 07/03/23, 09:37

  2. Mathias Brodala commented on patch set 1 07/03/23, 09:39

    SetupCommand.php:303

    For consistency there should be an empty line between these two.
  3. Jochen Roth uploaded patch set 2 07/03/23, 09:43

  4. core-ci voted on patch set 1 V +1 07/03/23, 09:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43205

  5. Mathias Brodala commented on patch set 2 CR +1 07/03/23, 09:46

    SetupCommand.php:303 Reply

    Done
  6. core-ci voted on patch set 2 V +1 07/03/23, 09:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43206

  7. Andreas Kienast commented on patch set 2 CR -1 07/03/23, 10:03

    temp -1: it looks like something else catches the `\RuntimeException` even without this patch, but doesn't return the correct exit code. I just tested this in a Symfony project, and `1` is returned as exit code.
  8. Mathias Brodala commented on patch set 2 07/03/23, 10:04

  9. Jochen Roth uploaded patch set 3 CR +1 V +1 07/03/23, 11:08

  10. core-ci voted on patch set 3 V +1 07/03/23, 11:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43219

  11. Andreas Kienast voted on patch set 3 V +1 CR +1 07/06/23, 10:23

  12. Benjamin Franzke voted on patch set 3 V +2 CR +2 07/06/23, 19:57

  13. Benjamin Franzke merged patch set 4 07/06/23, 19:57