79590[BUGFIX] Avoid PHP error in PHP 8 context in GifBuilder
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Oliver Klee +1
- Frank Nägler +1
- Stefan Bürk +1
- Andreas Kienast +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Oliver Klee +1
- Frank Nägler +1
- Stefan Bürk +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1213
-
Benni Mack uploaded patch set 1 07/03/23, 11:51
-
core-ci voted on patch set 1 V +1 07/03/23, 11:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43223
-
Oliver Klee commented on patch set 1 07/03/23, 12:03
Can we cover this with a test? -
Frank Nägler voted on patch set 1 V +1 CR +1 07/03/23, 16:25
-
Oli Bartsch voted on patch set 1 V +1 CR +1 07/03/23, 17:09
-
Andreas Kienast voted on patch set 1 V +1 CR +1 07/04/23, 07:55
-
Stefan Bürk voted on patch set 1 V +1 CR +1 07/04/23, 08:04
-
Benni Mack commented on patch set 1 07/04/23, 09:47
Reply
Waiting for feedback on the issue author on their TypoScript setup on how to reproduce this. This only seems to be a case when you use legacy (non-FAL) code, which I wasn't able to reproduce. Do you have any idea on how to create tests for this? -
Oliver Klee commented on patch set 1 07/04/23, 10:03
Reply
More or less … once we know the configuration/setup to reproduce the test, we can put it (or the minimal required configuration) in a test and check that the empty return value of the called method. (Without the fix, there should be a PHP warning.) -
Christian Kuhn commented on patch set 1 07/19/23, 09:12
Reply
hey. i think this is safe to merge since imageMagickConvert() can return null, and this return value is sanitized here. i'd accept this without test, since this is kinda hard to test anyways. -
Oliver Klee voted on patch set 1 V +1 CR +1 07/19/23, 09:38
-
Christian Kuhn voted on patch set 1 V +2 CR +2 07/19/23, 09:44
-
Christian Kuhn merged patch set 2 07/19/23, 09:44