79593[BUGFIX] Add better read-only settings.php handling to SilentUpgrade
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Andreas Kienast +1
- Benni Mack +1
-
Verified V +2 Done
- Stefan Bürk +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 8
- typo3/sysext/core/Classes/Configuration/Exception/SettingsWriteException.php2new+27 −0
- typo3/sysext/core/Classes/Configuration/ConfigurationManager.php+2 −1
- typo3/sysext/install/Classes/Command/UpgradeWizardRunCommand.php4+27 −1
- typo3/sysext/install/Classes/Controller/InstallerController.php+5 −1
- typo3/sysext/install/Classes/Controller/LayoutController.php+5 −1
- typo3/sysext/install/Classes/Service/Exception/SilentConfigurationUpgradeReadonlyException.php2new+37 −0
- typo3/sysext/install/Classes/Service/SilentConfigurationUpgradeService.php+2 −0
- typo3/sysext/install/Classes/ServiceProvider.php+2 −1
Review log 2533
Show 48 earlier messages
-
Susi Moog uploaded patch set 1 07/03/23, 17:55
-
core-ci voted on patch set 1 V -1 07/03/23, 18:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43275
-
Susi Moog uploaded patch set 2
V -107/04/23, 09:08 -
core-ci voted on patch set 2 V -1 07/04/23, 09:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43344
-
Susi Moog uploaded patch set 3
V -107/04/23, 09:41 -
core-ci voted on patch set 3 V -1 07/04/23, 09:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43352
-
Susi Moog uploaded patch set 4
V -107/04/23, 09:48 -
core-ci voted on patch set 4 V +1 07/04/23, 09:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43353
-
Susi Moog marked it ready for review 07/04/23, 09:58
-
Thomas Hohn commented on patch set 4 07/04/23, 11:10
SilentConfigurationUpgradeReadonlyException.php:2Could we add declare(strict_types=1); -
Oliver Klee commented on patch set 5
V +107/04/23, 12:05Published edit on patch set 4. -
Oliver Klee commented on patch set 5 07/04/23, 12:05
SettingsWriteException.php:2ReplyDoneSilentConfigurationUpgradeReadonlyException.php:2ReplyDone -
core-ci voted on patch set 5 V +1 07/04/23, 12:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43378
-
Thomas Hohn commented on patch set 5 07/04/23, 12:26
UpgradeWizardRunCommand.php:85And we are sure that this look will terminate - just asking ;-) -
Susi Moog uploaded patch set 6
V +107/06/23, 12:01 -
Susi Moog commented on patch set 6 07/06/23, 12:02
UpgradeWizardRunCommand.php:85Replynot sure enough to not implement loop safety ;) -
core-ci voted on patch set 6 V +1 07/06/23, 12:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43717
-
Andreas Kienast voted on patch set 6 CR +1 07/06/23, 13:07
-
Oliver Klee voted on patch set 6 CR +1 07/13/23, 22:15
-
Stefan Bürk commented on patch set 6 V +1 07/14/23, 09:10
UpgradeWizardRunCommand.php:86Can we add here some comments about the safety check - and the case why it is needed regarding how silent migrations are working. Something like that: ``` Single silent upgrade steps trigger a ConfigurationChangedException stopping the silent upgrade queue. Therfore, we need to re-try in that case to process all silent upgrades. The web installer handles this by recalling the process, whereas we do this in a loop here to avoid furstation on the user side to re-execute the command until all have been processed. In case of other issues, the loop is aborted to early inform about an issue. A hard limit is used as a guard against potential endlees loop if one silent upgrade task may contain a bug re-emitting this event even if nothing has changed. ``` -
Stefan Bürk commented on patch set 6 CR -1 07/14/23, 10:01
on it ... -
Stefan Bürk uploaded patch set 7
CR +1V +107/14/23, 10:15 -
Stefan Bürk commented on patch set 7 V +1 CR +1 07/14/23, 10:15
UpgradeWizardRunCommand.php:86ReplyDone -
Oliver Klee voted on patch set 7 CR +1 07/14/23, 10:16
-
core-ci voted on patch set 7 V +1 07/14/23, 10:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44133
-
Stefan Bürk rebased onto patch set 8
CR +1V +107/19/23, 22:52 -
Stefan Bürk voted on patch set 8 V +1 CR +1 07/19/23, 22:52
-
core-ci voted on patch set 8 V +1 07/19/23, 22:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44321
-
Andreas Kienast voted on patch set 8 CR +1 07/20/23, 07:39
-
Oliver Klee voted on patch set 8 CR +1 07/20/23, 07:57
-
Benni Mack voted on patch set 8 V +1 CR +1 07/21/23, 20:56
-
Stefan Bürk voted on patch set 8 V +2 CR +2 07/21/23, 20:59
-
Stefan Bürk merged patch set 9 07/21/23, 20:59
SettingsWriteException.php:2