Review main Merged

79593[BUGFIX] Add better read-only settings.php handling to SilentUpgrade

Susi Moog CR +2 V +2 Normal +107 −5 updated 07/21/23, 20:59

Commit message

The SilentUpgrade handles changes "under the hood" by migrating
old to new settings. If the settings.php is not writable, these
changes fail with an exception. As we cannot predict which side-
effects non-execution may have, we cannot allow further usage of
the install tool before those changes are done. We are now giving
the user a better error message and the option to run silent
upgrade with the normal CLI upgrade command.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 2533

Show 48 earlier messages
  1. Susi Moog uploaded patch set 1 07/03/23, 17:55

  2. core-ci voted on patch set 1 V -1 07/03/23, 18:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43275

  3. Susi Moog uploaded patch set 2 V -1 07/04/23, 09:08

  4. core-ci voted on patch set 2 V -1 07/04/23, 09:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43344

  5. Susi Moog uploaded patch set 3 V -1 07/04/23, 09:41

  6. core-ci voted on patch set 3 V -1 07/04/23, 09:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43352

  7. Susi Moog uploaded patch set 4 V -1 07/04/23, 09:48

  8. core-ci voted on patch set 4 V +1 07/04/23, 09:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43353

  1. Susi Moog marked it ready for review 07/04/23, 09:58

  2. Thomas Hohn commented on patch set 4 07/04/23, 11:10

    SettingsWriteException.php:2

    Could we add declare(strict_types=1);

    SilentConfigurationUpgradeReadonlyException.php:2

    Could we add declare(strict_types=1);
  3. Oliver Klee commented on patch set 5 V +1 07/04/23, 12:05

    Published edit on patch set 4.
  4. Oliver Klee commented on patch set 5 07/04/23, 12:05

    SettingsWriteException.php:2 Reply

    Done

    SilentConfigurationUpgradeReadonlyException.php:2 Reply

    Done
  5. core-ci voted on patch set 5 V +1 07/04/23, 12:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43378

  6. Thomas Hohn commented on patch set 5 07/04/23, 12:26

    UpgradeWizardRunCommand.php:85

    And we are sure that this look will terminate - just asking ;-)
  7. Susi Moog uploaded patch set 6 V +1 07/06/23, 12:01

  8. Susi Moog commented on patch set 6 07/06/23, 12:02

    UpgradeWizardRunCommand.php:85 Reply

    not sure enough to not implement loop safety ;)
  9. core-ci voted on patch set 6 V +1 07/06/23, 12:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43717

  10. Andreas Kienast voted on patch set 6 CR +1 07/06/23, 13:07

  11. Oliver Klee voted on patch set 6 CR +1 07/13/23, 22:15

  12. Stefan Bürk commented on patch set 6 V +1 07/14/23, 09:10

    UpgradeWizardRunCommand.php:86

    Can we add here some comments about the safety check - and the case why it is needed regarding how silent migrations are working. Something like that: ``` Single silent upgrade steps trigger a ConfigurationChangedException stopping the silent upgrade queue. Therfore, we need to re-try in that case to process all silent upgrades. The web installer handles this by recalling the process, whereas we do this in a loop here to avoid furstation on the user side to re-execute the command until all have been processed. In case of other issues, the loop is aborted to early inform about an issue. A hard limit is used as a guard against potential endlees loop if one silent upgrade task may contain a bug re-emitting this event even if nothing has changed. ```
  13. Stefan Bürk commented on patch set 6 CR -1 07/14/23, 10:01

    on it ...
  14. Stefan Bürk uploaded patch set 7 CR +1 V +1 07/14/23, 10:15

  15. Stefan Bürk commented on patch set 7 V +1 CR +1 07/14/23, 10:15

    UpgradeWizardRunCommand.php:86 Reply

    Done
  16. Oliver Klee voted on patch set 7 CR +1 07/14/23, 10:16

  17. core-ci voted on patch set 7 V +1 07/14/23, 10:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44133

  18. Stefan Bürk rebased onto patch set 8 CR +1 V +1 07/19/23, 22:52

  19. Stefan Bürk voted on patch set 8 V +1 CR +1 07/19/23, 22:52

  20. core-ci voted on patch set 8 V +1 07/19/23, 22:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44321

  21. Andreas Kienast voted on patch set 8 CR +1 07/20/23, 07:39

  22. Oliver Klee voted on patch set 8 CR +1 07/20/23, 07:57

  23. Benni Mack voted on patch set 8 V +1 CR +1 07/21/23, 20:56

  24. Stefan Bürk voted on patch set 8 V +2 CR +2 07/21/23, 20:59

  25. Stefan Bürk merged patch set 9 07/21/23, 20:59