Review main Merged

79616[BUGFIX] Don't treat CKEditor Inspector as CommonJS

Andreas Nedbal CR +2 V +2 Easy +2 −9 updated 07/03/23, 14:52

Commit message

This change in the Rollup configuration caused the window
namespace to disappear, breaking the JS call in the process.

Review

  • Code review CR +2 Done
    • Andreas Nedbal +2
    • Thomas Hohn +1
    • Jochen Roth +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Andreas Nedbal +2
    • Jochen Roth +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 67

  1. Andreas Nedbal uploaded patch set 1 07/03/23, 14:24

  2. core-ci voted on patch set 1 V +1 07/03/23, 14:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43239

  3. Andreas Kienast voted on patch set 1 V +1 CR +1 07/03/23, 14:39

  4. Jochen Roth voted on patch set 1 V +1 CR +1 07/03/23, 14:39

  5. Thomas Hohn voted on patch set 1 CR +1 07/03/23, 14:45

  6. Andreas Nedbal voted on patch set 1 V +2 CR +2 07/03/23, 14:52

  7. Andreas Nedbal merged patch set 2 07/03/23, 14:52