Review main Merged

79619[BUGFIX] Show validation errors for fields with legend in form engine

Oli Bartsch CR +2 V +2 Easy +11 −5 updated 07/03/23, 19:50

Commit message

Since #97330, a form engine elements label
might not be represented by a <label> tag,
but by using a <legend> tag.

This patch now ensures that those elements
are also correctly considered within form
engine validation.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 914

  1. Oli Bartsch uploaded patch set 1 07/03/23, 15:21

  2. Oli Bartsch uploaded patch set 2 07/03/23, 15:23

  3. Lina Wolf updated the commit message in patch set 3 07/03/23, 15:26

  4. core-ci voted on patch set 1 V -1 07/03/23, 15:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43248

  5. core-ci voted on patch set 2 V -1 07/03/23, 15:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43252

  6. core-ci voted on patch set 3 V -1 07/03/23, 15:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43256

  7. Oli Bartsch uploaded patch set 4 V -1 07/03/23, 16:14

  8. Andreas Kienast rebased onto patch set 5 07/03/23, 16:16

  9. Andreas Kienast voted on patch set 5 V +1 CR +1 07/03/23, 16:18

  10. core-ci voted on patch set 5 V +1 07/03/23, 16:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43262

  11. core-ci voted on patch set 4 V +1 07/03/23, 16:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43261

  12. Jochen Roth voted on patch set 5 V +1 CR +1 07/03/23, 19:47

  13. Oli Bartsch voted on patch set 5 V +2 CR +2 07/03/23, 19:50

  14. Oli Bartsch merged patch set 6 07/03/23, 19:50