79623[BUGFIX] Do not create auto-create redirects for SysFolder and Spacer
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Lina Wolf +1
- Benni Mack +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Benni Mack +1
Issues 1
Files 5
- typo3/sysext/redirects/Classes/EventListener/AddPageTypeZeroSource.php2+14 −0
- typo3/sysext/redirects/Classes/EventListener/AddPlainSlugReplacementSource.php2+14 −0
- typo3/sysext/redirects/Tests/Functional/Service/Fixtures/SpacerSubPages_Test1.csvnew+7 −0
- typo3/sysext/redirects/Tests/Functional/Service/Fixtures/SysFolderSubPages_Test1.csvnew+7 −0
- typo3/sysext/redirects/Tests/Functional/Service/SlugServiceTest.php+58 −0
Review log 1214
-
Stefan Bürk uploaded patch set 1 07/03/23, 19:27
-
Stefan Bürk updated the commit message in patch set 2 07/03/23, 19:28
-
Oliver Klee commented on patch set 2 07/03/23, 19:36
Looks very good to me! I’ve added two minor remarks.AddPageTypeZeroSource.php:44We can be more specific here (and also in the other class that uses the same pattern): ``` * @var list<PageRepository::DOKTYPE_*> ```AddPlainSlugReplacementSource.php:45I propose having a blank line after the guard clause to make the structure of the method easier to grasp at the first glance. -
core-ci voted on patch set 2 V +1 07/03/23, 19:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43286
-
core-ci voted on patch set 1 V +1 07/03/23, 19:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43285
-
Stefan Bürk uploaded patch set 3
V +107/03/23, 20:08 -
Stefan Bürk commented on patch set 3 07/03/23, 20:08
AddPageTypeZeroSource.php:44ReplyDoneAddPlainSlugReplacementSource.php:45ReplyDone -
Oliver Klee voted on patch set 3 V +1 CR +1 07/03/23, 20:11
-
Lina Wolf commented on patch set 3 CR +1 07/04/23, 06:43
I think this is a good idea. -
Andreas Kienast commented on patch set 3 07/04/23, 07:17
The same is for recycler, isn't it? Since we have that kind of check at several locations, would it make sense to have a `PageRepository::PRIVATE_DOKTYPES` array constant or alike? -
Stefan Bürk commented on patch set 3 07/04/23, 08:18
Reply
In main that doktype is removed -> https://review.typo3.org/c/Packages/TYPO3.CMS/+/79472. I guess for 12.4 backport it would make sense, yes. However, I guess a recyler doktypes are not that much used . and if, they are most likely not often changed regarding the slug field by an editor. Quite unsure about the class constants. It's not really about "private" . it's only a ignore for auto-create not influencing other stuff - so I guess not mixing it somewhere else with other definitiosn about "private" doktypes is the more suitable way. What do you think ? -
Benni Mack voted on patch set 3 V +1 CR +1 07/04/23, 09:49
-
Stefan Bürk voted on patch set 3 V +2 CR +2 07/04/23, 09:54
-
Stefan Bürk merged patch set 4 07/04/23, 09:54