Review main Merged

79623[BUGFIX] Do not create auto-create redirects for SysFolder and Spacer

Stefan Bürk CR +2 V +2 Normal +100 −0 updated 07/04/23, 09:54

Commit message

Creating redirects for `SysFolder` and `Spacer` on slug changes does
not make sense as they are not reachable in the frontend. Updating
child pages if they start with the orignal slug however is a wanted
behaviour following the normal page type behaviour.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Lina Wolf +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Benni Mack +1

Issues 1

Files 5

Review log 1214

  1. Stefan Bürk uploaded patch set 1 07/03/23, 19:27

  2. Stefan Bürk updated the commit message in patch set 2 07/03/23, 19:28

  3. Oliver Klee commented on patch set 2 07/03/23, 19:36

    Looks very good to me! I’ve added two minor remarks.

    AddPageTypeZeroSource.php:44

    We can be more specific here (and also in the other class that uses the same pattern): ``` * @var list<PageRepository::DOKTYPE_*> ```

    AddPlainSlugReplacementSource.php:45

    I propose having a blank line after the guard clause to make the structure of the method easier to grasp at the first glance.
  4. core-ci voted on patch set 2 V +1 07/03/23, 19:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43286

  5. core-ci voted on patch set 1 V +1 07/03/23, 19:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43285

  6. Stefan Bürk uploaded patch set 3 V +1 07/03/23, 20:08

  7. Stefan Bürk commented on patch set 3 07/03/23, 20:08

    AddPageTypeZeroSource.php:44 Reply

    Done

    AddPlainSlugReplacementSource.php:45 Reply

    Done
  8. Oliver Klee voted on patch set 3 V +1 CR +1 07/03/23, 20:11

  9. Lina Wolf commented on patch set 3 CR +1 07/04/23, 06:43

    I think this is a good idea.
  10. Andreas Kienast commented on patch set 3 07/04/23, 07:17

    The same is for recycler, isn't it? Since we have that kind of check at several locations, would it make sense to have a `PageRepository::PRIVATE_DOKTYPES` array constant or alike?
  11. Stefan Bürk commented on patch set 3 07/04/23, 08:18

    Reply

    In main that doktype is removed -> https://review.typo3.org/c/Packages/TYPO3.CMS/+/79472. I guess for 12.4 backport it would make sense, yes. However, I guess a recyler doktypes are not that much used . and if, they are most likely not often changed regarding the slug field by an editor. Quite unsure about the class constants. It's not really about "private" . it's only a ignore for auto-create not influencing other stuff - so I guess not mixing it somewhere else with other definitiosn about "private" doktypes is the more suitable way. What do you think ?
  12. Benni Mack voted on patch set 3 V +1 CR +1 07/04/23, 09:49

  13. Stefan Bürk voted on patch set 3 V +2 CR +2 07/04/23, 09:54

  14. Stefan Bürk merged patch set 4 07/04/23, 09:54