Review 12.4 Merged

79653[BUGFIX] Fix undo operation for RowUpdater UpgradeWizards

Susi Moog CR +2 V +2 Easy +15 −1 updated 07/05/23, 14:41

Commit message

With the refactoring to attributes, RowUpdaters failed
to be fetched from the UpgradeWizardService, as they present
upgrade wizards in the registry but are not registered via
the UgradeWizard service locator.

To fix this gracefully, we avoid using the service locator for row
updaters, falling back to the identifier.

A next step (feature) would be the introduction of a dedicated
attribute and service locator for RowUpdaters.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 711

  1. Susi Moog uploaded patch set 1 07/04/23, 07:14

  2. core-ci voted on patch set 1 V -1 07/04/23, 07:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43332

  3. core-ci voted on patch set 1 V +1 07/04/23, 07:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43332

  4. Susi Moog commented on patch set 2 V +1 07/04/23, 08:11

    Published edit on patch set 1.
  5. Christian Kuhn voted on patch set 2 CR +1 07/04/23, 08:13

  6. core-ci voted on patch set 2 V +1 07/04/23, 08:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43339

  7. Benjamin Franzke uploaded patch set 3 CR +1 V +1 07/04/23, 13:57

  8. Benjamin Franzke voted on patch set 3 V +1 CR +1 07/04/23, 13:59

  9. core-ci voted on patch set 3 V +1 07/04/23, 14:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43391

  10. Benni Mack voted on patch set 3 V +2 CR +2 07/05/23, 14:41

  11. Benni Mack merged patch set 4 07/05/23, 14:41