Review main Merged

79656[BUGFIX] Check rootline for extendToSubpages when previewing

Susi Moog CR +2 V +2 Easy +45 −2 updated 07/06/23, 20:06

Commit message

The rootline may contain extendToSubpages settings for hidden
or timed records which prevented previewing a page because the
preview checks only considered the current page.

The rootline is now taken into account.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Frank Nägler +1
  • Verified V +2 Done
    • Benni Mack +2
    • Frank Nägler +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1015

  1. Susi Moog uploaded patch set 1 07/06/23, 08:29

  2. Benni Mack commented on patch set 1 CR -1 07/06/23, 10:19

    do not inject PageRepository, as this will force the wrong context
  3. core-ci voted on patch set 1 V -1 07/06/23, 10:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43667

  4. Susi Moog uploaded patch set 2 CR -1 V -1 07/06/23, 11:35

  5. Susi Moog uploaded patch set 3 07/06/23, 11:53

  6. core-ci voted on patch set 2 V -1 07/06/23, 11:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43707

  7. core-ci voted on patch set 3 V -1 07/06/23, 12:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43713

  8. Susi Moog uploaded patch set 4 V -1 07/06/23, 14:36

  9. core-ci voted on patch set 4 V -1 07/06/23, 14:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43760

  10. Benni Mack uploaded patch set 5 V -1 07/06/23, 16:31

  11. core-ci voted on patch set 5 V +1 07/06/23, 16:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43774

  12. Benni Mack voted on patch set 5 V +1 CR +1 07/06/23, 16:44

  13. Frank Nägler voted on patch set 5 V +1 CR +1 07/06/23, 20:03

  14. Benni Mack voted on patch set 5 V +2 CR +2 07/06/23, 20:06

  15. Benni Mack merged patch set 6 07/06/23, 20:06