Review 11.5 Merged

79676[BUGFIX] Avoid symfony/property-access in getGettablePropertyNames()

Benni Mack CR +2 V +2 Normal +54 −18 updated 07/04/23, 13:10

Commit message

ObjectAccess::getGettablePropertyNames() has quite the history by now.
It used to be quite simple, an is_callable() check for getters/hassers
and issers of objects. That didn't account for methods with mandatory
method arguments which was fixed by using reflection. Because runtime
reflection is slow, the usage of cached reflection (ClassSchema) had
been introduced. But, during that change, symfony/property-access had
also been introduces, which contradicts the idea of performance gain
because:

- symfony/property-access also uses uncached reflection
- symfony/property-access actually calls the accessors under test

As both is undesirable, the usage of symfony/property-access has been
removed again.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Benni Mack commented on patch set 1 07/04/23, 09:50

    Cherry Picked from branch 12.4. The following files contain Git conflicts: * typo3/sysext/extbase/Classes/Reflection/ObjectAccess.php
  2. Benni Mack commented on patch set 2 07/04/23, 10:13

    Published edit on patch set 1.
  3. Benni Mack marked it ready for review 07/04/23, 10:15

  4. core-ci voted on patch set 2 V +1 07/04/23, 10:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43359

  5. core-ci voted on patch set 1 V -1 07/04/23, 10:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43355

  6. Benni Mack voted on patch set 2 V +2 CR +2 07/04/23, 13:10

  7. Benni Mack merged patch set 3 07/04/23, 13:10