79698[BUGFIX] Consider path links with leading slash as `url`
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Hader +1
- Benni Mack +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Hader +1
- Benni Mack +1
- core-ci +1 CI
Issues 3
Files 10
- typo3/sysext/core/Classes/LinkHandling/LegacyLinkNotationConverter.php3+11 −0
- typo3/sysext/core/Classes/LinkHandling/UrlLinkHandler.php2+2 −1
- typo3/sysext/core/Tests/Unit/DataHandling/SoftReference/TypoLinkSoftReferenceParserTest.php+4 −0
- typo3/sysext/core/Tests/Unit/LinkHandling/UrlLinkHandlerTest.php+25 −0
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+8 −13
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewExportPageAndRecords.php+8 −24
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewExportRecords.php+3 −19
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewExportTable.php+5 −21
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/pages-and-ttcontent-complex.xml+103 −149
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/pages-and-ttcontent.xml3+234 −280
Review log 2738
Show 713 earlier messages
-
Stefan Bürk uploaded patch set 1 07/04/23, 11:44
-
Oliver Klee commented on patch set 1 07/04/23, 11:48
Is the issue number still missing here? -
core-ci voted on patch set 1 V +1 07/04/23, 11:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43372
-
Stefan Bürk updated the commit message in patch set 2
V +107/04/23, 12:55 -
core-ci voted on patch set 2 V +1 07/04/23, 13:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43380
-
Benni Mack uploaded patch set 3
V +107/04/23, 16:15 -
core-ci voted on patch set 3 V -1 07/04/23, 16:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43403
-
Benni Mack uploaded patch set 4
V -107/04/23, 18:20 -
core-ci voted on patch set 4 V -1 07/04/23, 18:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43417
-
Benni Mack commented on patch set 5
V -107/04/23, 19:10Published edit on patch set 4. -
core-ci voted on patch set 5 V -1 07/04/23, 19:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43419
-
Stefan Bürk uploaded patch set 6
V -107/05/23, 07:38 -
core-ci voted on patch set 6 V -1 07/05/23, 07:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43466
-
Oliver Klee commented on patch set 6 07/05/23, 07:54
Reply
Done -
Stefan Bürk uploaded patch set 7
V -107/05/23, 08:02 -
core-ci voted on patch set 7 V +1 07/05/23, 08:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43469
-
Oliver Klee wrote 07/05/23, 08:15
Removed cc Oliver Klee. -
Oliver Klee voted on patch set 7 V +1 07/05/23, 08:16
-
Oliver Klee commented on patch set 7 07/05/23, 08:18
LegacyLinkNotationConverter.php:222$fileOrFolderObject is an object or null here, not a boolean. To make this more obvious to the reader (and to help static code analysis), I propose we change this to `if ($fileOrFolderObject instanceof … && …`.UrlLinkHandler.php:52If we have this, we can drop the condition above - because if it starts with two slashes, it also starts with one slash. :-) -
Stefan Bürk uploaded patch set 8
V +107/05/23, 08:49 -
Stefan Bürk commented on patch set 7 07/05/23, 08:49
LegacyLinkNotationConverter.php:222ReplyWouldn't be an `!== null`enough ? instead of multiple instance checks then ?UrlLinkHandler.php:52ReplyDone -
Stefan Bürk uploaded patch set 9 07/05/23, 08:53
-
core-ci voted on patch set 8 V +1 07/05/23, 08:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43472
-
Oliver Klee voted on patch set 9 CR +1 07/05/23, 08:59
-
Stefan Bürk uploaded patch set 10
CR +107/05/23, 09:05 -
core-ci voted on patch set 9 V +1 07/05/23, 09:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43473
-
Oliver Klee commented on patch set 10 CR +1 07/05/23, 09:12
LegacyLinkNotationConverter.php:222ReplyDone -
core-ci voted on patch set 10 V +1 07/05/23, 09:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43476
-
Oliver Klee voted on patch set 10 V +1 07/05/23, 09:31
-
Oliver Hader commented on patch set 10 07/05/23, 10:27
pages-and-ttcontent.xml:79I don't know whether this will work (without having it tested). Previously the reference was defined by `db` and the target `sys_file:4` - now it's just `external` and `4` → thus, there does not seem to be any hint anymore, that it actually would be a file... I might be, that is not relevant anymore - however, I just don't know - this would have to be tested manually again. -
Benni Mack updated the commit message in patch set 11
CR +1V +107/05/23, 10:30 -
core-ci voted on patch set 11 V +1 07/05/23, 10:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43483
-
Oliver Hader commented on patch set 11 07/05/23, 10:44
pages-and-ttcontent.xml:79ReplyIn my manual test (export) it looks like this: ``` <rec index="516" type="array"> <uid>516</uid> <pid>401</pid> <title>Test</title> <relations index="rels" type="array"></relations> <softrefs type="array"> <softref_element index="header_link:typolink:463f336836889120d6205bbbad342319:0" type="array"> <field>header_link</field> <spKey>typolink</spKey> <matchString>file:230</matchString> <subst type="array"> <type>db</type> <recordRef>sys_file:230</recordRef> <tokenID>463f336836889120d6205bbbad342319</tokenID> <tokenValue>file:230</tokenValue> </subst> </softref_element> </softrefs> </rec> ``` -
Oliver Hader commented on patch set 11 V +1 CR +1 07/05/23, 12:21
pages-and-ttcontent.xml:79ReplyReason is, that `file:4` is used as field value (instead of using the absolute path `/foo/filename.png`... -
Benni Mack voted on patch set 11 V +1 CR +1 07/05/23, 12:33
-
Stefan Bürk voted on patch set 11 V +2 CR +2 07/05/23, 12:38
-
Stefan Bürk merged patch set 12 07/05/23, 12:39
-
Josef Glatz commented on patch set 12 03/11/24, 08:42
Unresolved
Looks like the backport for 12.4 of this patch is not working anymore. I've updated the issue status therefore in forge. Hope this is ok, otherwise I will create a new issue @benni@typo3.org @stefan@buerk.tech