Review main Merged

79701[TASK] Update CKEditor5 to use DocumentList instead of List

Benjamin Serfhos CR +2 V +2 Nightmare +2124 −1674 updated 08/30/23, 08:57

Commit message

See: https://github.com/ckeditor/ckeditor5/issues/14200#issuecomment-1625171318

This allows similar behaviour as CKEditor 4 with applying styles to block components as DocumentList is preferred over List.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Torben Hansen +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Jakub Zgirski +1
    • Torben Hansen +1
    • Riccardo De Contardi +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1316

  1. Benjamin Serfhos uploaded patch set 1 07/04/23, 14:37

  2. Benjamin Serfhos updated the commit message in patch set 2 07/04/23, 14:40

  3. core-ci voted on patch set 1 V +1 07/04/23, 14:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43396

  4. core-ci voted on patch set 2 V +1 07/04/23, 14:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43397

  5. Benjamin Serfhos updated the commit message in patch set 3 V +1 07/10/23, 10:40

  6. core-ci voted on patch set 3 V +1 07/10/23, 10:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43979

  7. Riccardo De Contardi commented on patch set 3 V +1 08/04/23, 08:19

    tested on latest main - with the patch I've been able to add a class to the UL tag (see the forge issue for the YAML code)
  8. Patrick Schriner commented on patch set 3 08/04/23, 10:15

    If I understand the TYPO3 way of handling the ckeditor5 config right you have to pass the `list` options explicitly, similiar to what is done in https://review.typo3.org/c/Packages/TYPO3.CMS/+/79015
  9. Sven Carstens commented on patch set 3 08/08/23, 09:36

    Reply

    At least for my use-case this patch is sufficient. I don't know if all options are available in the tools of the RTE, but at least the styling of UL is possible again and doesn't get filtered out by ckeditor.
  10. Benjamin Serfhos commented on patch set 3 08/09/23, 12:39

    Reply

    If we are going to implement the whole DocumentList implementation this issue will not be a bugfix but a new feature implementation. If we want to add this fine, but its definitely not part of issue #100348. This patch is only to revert old CKEditor4 functionality as mentioned in the description.
  11. Benni Mack commented on patch set 3 08/18/23, 10:46

    see https://github.com/ckeditor/ckeditor5/issues/14767 - DocumentList is going to be renamed to List again :) I'm fine to add also new necessary features to TYPO3 v12 CKEditor implementation if this helps to ease the pain of migrating to v12.
  12. Jakub Zgirski commented on patch set 3 V +1 08/22/23, 13:22

    Works for me.
  13. Torben Hansen commented on patch set 3 V +1 CR +1 08/26/23, 05:30

    As soon as `DocumentList` gets renamed to `List` (when `List` is deprecated/removed from CKEditor), we must use (the new) `List` again. I subscribed the Github issue Benni linked in order to get updates on the task.
  14. Christian Kuhn voted on patch set 3 V +1 CR +1 08/30/23, 08:51

  15. Andreas Kienast voted on patch set 3 V +2 CR +2 08/30/23, 08:57

  16. Andreas Kienast merged patch set 4 08/30/23, 08:57