Review main Merged

79702[BUGFIX] Properly respect "disallowed" list for file extensions

Oli Bartsch CR +2 V +2 Normal +146 −54 updated 07/04/23, 20:28

Commit message

Maintaining the "disallowed" list in TCA for type=file
previously was only respected in the DataHandler
but the restriction was not displayed neither in
FormEngine nor in the FileBrowser. Additionally,
the file extension filter did not restrict available
files to select and the list was also not used by
the DragUploader.

All those places are now unified.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 1623

  1. Oli Bartsch uploaded patch set 1 07/04/23, 15:16

  2. core-ci voted on patch set 1 V -1 07/04/23, 15:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43399

  3. Oli Bartsch uploaded patch set 2 V -1 07/04/23, 15:58

  4. core-ci voted on patch set 2 V -1 07/04/23, 16:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43401

  5. Oli Bartsch uploaded patch set 3 V -1 07/04/23, 16:14

  6. core-ci voted on patch set 3 V -1 07/04/23, 16:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43402

  7. Oli Bartsch uploaded patch set 4 V -1 07/04/23, 16:30

  8. Oli Bartsch uploaded patch set 5 07/04/23, 16:36

  9. core-ci voted on patch set 4 V +1 07/04/23, 16:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43404

  10. core-ci voted on patch set 5 V +1 07/04/23, 16:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43405

  11. Oli Bartsch updated the commit message in patch set 6 V +1 07/04/23, 17:16

  12. core-ci voted on patch set 6 V +1 07/04/23, 17:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43409

  13. Jochen Roth voted on patch set 6 V +1 CR +1 07/04/23, 18:11

  14. Benni Mack commented on patch set 6 07/04/23, 19:02

    FileExtensionFilter.php:166

    what does "resolved" mean in this context? I mean, reading this patch now makes it understandable, but in 5 years, it's hard to grasp.
  15. Oli Bartsch commented on patch set 6 07/04/23, 19:20

    FileExtensionFilter.php:166 Reply

    It means comparing allowed and disallowed and returning a list of extensions, either an allow or disallow list, based on the given configuration. Do you have any suggestion for a better naming?
  16. Benni Mack commented on patch set 6 07/04/23, 19:37

    FileExtensionFilter.php:166 Reply

    "getFilteredFileExtensions()" or "getAvailableFileExtensions()" or "getEnabledFileExtensions()" or add a comment above the method?
  17. Oli Bartsch uploaded patch set 7 CR +1 V +1 07/04/23, 19:41

  18. Oli Bartsch commented on patch set 7 07/04/23, 19:42

    FileExtensionFilter.php:166 Reply

    Change the function name and also added a corresponding comment.
  19. core-ci voted on patch set 7 V +1 07/04/23, 19:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43425

  20. Benni Mack voted on patch set 7 V +1 CR +1 07/04/23, 19:56

  21. Jochen Roth voted on patch set 7 V +1 CR +1 07/04/23, 19:57

  22. Oli Bartsch voted on patch set 7 V +2 CR +2 07/04/23, 20:28

  23. Oli Bartsch merged patch set 8 07/04/23, 20:28