79702[BUGFIX] Properly respect "disallowed" list for file extensions
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 9
- Build/Sources/TypeScript/backend/drag-uploader.ts+17 −0
- typo3/sysext/backend/Classes/Form/Container/FilesControlContainer.php+16 −9
- typo3/sysext/backend/Classes/View/FolderUtilityRenderer.php+35 −26
- typo3/sysext/backend/Resources/Private/Templates/Form/FilesControlContainer.html+16 −8
- typo3/sysext/backend/Resources/Public/JavaScript/drag-uploader.js+1 −1
- typo3/sysext/core/Classes/Resource/Filter/FileExtensionFilter.php4+31 −0
- typo3/sysext/core/Resources/Private/Language/locallang_core.xlf+6 −0
- typo3/sysext/filelist/Classes/ElementBrowser/FileBrowser.php+23 −9
- typo3/sysext/filelist/Classes/LinkHandler/FileLinkHandler.php+1 −1
Review log 1623
-
Oli Bartsch uploaded patch set 1 07/04/23, 15:16
-
core-ci voted on patch set 1 V -1 07/04/23, 15:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43399
-
Oli Bartsch uploaded patch set 2
V -107/04/23, 15:58 -
core-ci voted on patch set 2 V -1 07/04/23, 16:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43401
-
Oli Bartsch uploaded patch set 3
V -107/04/23, 16:14 -
core-ci voted on patch set 3 V -1 07/04/23, 16:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43402
-
Oli Bartsch uploaded patch set 4
V -107/04/23, 16:30 -
Oli Bartsch uploaded patch set 5 07/04/23, 16:36
-
core-ci voted on patch set 4 V +1 07/04/23, 16:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43404
-
core-ci voted on patch set 5 V +1 07/04/23, 16:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43405
-
Oli Bartsch updated the commit message in patch set 6
V +107/04/23, 17:16 -
core-ci voted on patch set 6 V +1 07/04/23, 17:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43409
-
Jochen Roth voted on patch set 6 V +1 CR +1 07/04/23, 18:11
-
Benni Mack commented on patch set 6 07/04/23, 19:02
-
Oli Bartsch commented on patch set 6 07/04/23, 19:20
FileExtensionFilter.php:166ReplyIt means comparing allowed and disallowed and returning a list of extensions, either an allow or disallow list, based on the given configuration. Do you have any suggestion for a better naming? -
Benni Mack commented on patch set 6 07/04/23, 19:37
FileExtensionFilter.php:166Reply"getFilteredFileExtensions()" or "getAvailableFileExtensions()" or "getEnabledFileExtensions()" or add a comment above the method? -
Oli Bartsch uploaded patch set 7
CR +1V +107/04/23, 19:41 -
Oli Bartsch commented on patch set 7 07/04/23, 19:42
FileExtensionFilter.php:166ReplyChange the function name and also added a corresponding comment. -
core-ci voted on patch set 7 V +1 07/04/23, 19:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43425
-
Benni Mack voted on patch set 7 V +1 CR +1 07/04/23, 19:56
-
Jochen Roth voted on patch set 7 V +1 CR +1 07/04/23, 19:57
-
Oli Bartsch voted on patch set 7 V +2 CR +2 07/04/23, 20:28
-
Oli Bartsch merged patch set 8 07/04/23, 20:28
FileExtensionFilter.php:166