Review main Merged

79708[BUGFIX] Properly show indeterminate state of categories

Andreas Nedbal CR +2 V +2 Easy +12 −12 updated 07/05/23, 08:08

Commit message

Prepared nodes were not properly handled in the category
element, causing the  indetermination state recalculation to
never trigger properly. Using the nodes from the
nodes-prepared event fixes this issue.

Review

  • Code review CR +2 Done
    • Andreas Nedbal +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Andreas Nedbal +2
    • Oli Bartsch +1
    • Annett Jähnichen +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1417

  1. Andreas Nedbal uploaded patch set 1 07/04/23, 19:41

  2. Oli Bartsch commented on patch set 1 07/04/23, 19:45

    category-element.ts:126

    We have the same code in the select tree element. This should be adjusted accordingly.
  3. core-ci voted on patch set 1 V +1 07/04/23, 19:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43424

  4. Andreas Nedbal uploaded patch set 2 V +1 07/04/23, 19:54

  5. Andreas Nedbal commented on patch set 2 07/04/23, 19:55

    category-element.ts:126 Reply

    Done
  6. core-ci voted on patch set 2 V +1 07/04/23, 20:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43426

  7. Stefan Bürk voted on patch set 2 V +1 CR +1 07/04/23, 20:13

  8. Benni Mack voted on patch set 2 V +1 CR +1 07/04/23, 20:29

  9. Oli Bartsch commented on patch set 2 CR -1 07/04/23, 21:33

    When I uncheck a child, the intermediate state on the parent is not reset. Only after saving the record, the state is reseted.
  10. Andreas Nedbal uploaded patch set 3 CR +1 V +1 07/05/23, 07:35

  11. Andreas Nedbal commented on patch set 3 07/05/23, 07:35

    Reply

    Done
  12. core-ci voted on patch set 3 V +1 07/05/23, 07:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43465

  13. Oli Bartsch voted on patch set 3 V +1 CR +1 07/05/23, 07:54

  14. Annett Jähnichen voted on patch set 3 V +1 07/05/23, 07:54

  15. Stefan Bürk voted on patch set 3 V +1 CR +1 07/05/23, 08:06

  16. Andreas Nedbal voted on patch set 3 V +2 CR +2 07/05/23, 08:08

  17. Andreas Nedbal merged patch set 4 07/05/23, 08:08