Review main Merged

79711[TASK] Remove jQuery from EXT:opendocs

Andreas Kienast CR +2 V +2 Normal +36 −42 updated 07/05/23, 10:58

Commit message

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1013

  1. Andreas Kienast uploaded patch set 1 07/05/23, 07:07

  2. core-ci voted on patch set 1 V +1 07/05/23, 07:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43455

  3. Thomas Hohn voted on patch set 1 CR +1 07/05/23, 07:17

  4. Benjamin Franzke uploaded patch set 2 CR +1 V +1 07/05/23, 07:34

  5. Benjamin Franzke commented on patch set 2 07/05/23, 07:34

    opendocs-menu.ts:61

    Changed to .textContent = (innerText is heavier, textContent should suffice here – see https://stackoverflow.com/a/35213639 )
  6. core-ci voted on patch set 2 V +1 07/05/23, 07:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43464

  7. Andreas Kienast commented on patch set 2 07/05/23, 08:00

    opendocs-menu.ts:61 Reply

    Thanks
  8. Oli Bartsch commented on patch set 2 CR -1 07/05/23, 10:18

    opendocs-menu.ts:116

    This has no effect.
  9. Oli Bartsch uploaded patch set 3 CR +1 V +1 07/05/23, 10:34

  10. Oli Bartsch commented on patch set 3 V +1 CR +1 07/05/23, 10:39

    opendocs-menu.ts:116 Reply

    Done
  11. core-ci voted on patch set 3 V +1 07/05/23, 10:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43484

  12. Benjamin Franzke voted on patch set 3 V +2 CR +2 07/05/23, 10:58

  13. Benjamin Franzke merged patch set 4 07/05/23, 10:58