79712[TASK] Remove @internal for MfaProvider classes
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Andreas Kienast +1
-
Verified V +2 Done
- Oli Bartsch +2
- Andreas Kienast +1
- core-ci +1 CI
Issues 3
Files 6
- typo3/sysext/core/Classes/Authentication/Mfa/MfaProviderInterface.php+0 −2
- typo3/sysext/core/Classes/Authentication/Mfa/MfaProviderManifest.php2+1 −1
- typo3/sysext/core/Classes/Authentication/Mfa/MfaProviderManifestInterface.php2+1 −1
- typo3/sysext/core/Classes/Authentication/Mfa/MfaProviderPropertyManager.php+0 −2
- typo3/sysext/core/Classes/Authentication/Mfa/MfaProviderRegistry.php2+1 −1
- typo3/sysext/core/Classes/Authentication/Mfa/MfaViewType.php+0 −2
Review log 1924
-
Thomas Hohn uploaded patch set 1 07/05/23, 08:54
-
Oliver Klee voted on patch set 1 V +1 CR +1 07/05/23, 08:54
-
core-ci voted on patch set 1 V +1 07/05/23, 09:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43474
-
Benni Mack commented on patch set 1 07/05/23, 09:16
shouldn't they be removed in 12.4 then as well? -
Thomas Hohn commented on patch set 1 07/05/23, 09:17
Reply
We could do that too 😊 -
Thomas Hohn updated the commit message in patch set 2
CR +1V +107/05/23, 09:18 -
core-ci voted on patch set 2 V +1 07/05/23, 09:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43478
-
Benjamin Franzke voted on patch set 2 V +1 CR +1 07/05/23, 09:30
-
Oliver Klee voted on patch set 2 V +1 CR +1 07/05/23, 09:31
-
Oli Bartsch commented on patch set 2 07/05/23, 09:51
Reply
Actually this should have been removed with 11 LTS already. ;) -
Thomas Hohn uploaded patch set 3
CR +1V +107/05/23, 09:57 -
Oli Bartsch commented on patch set 3 07/05/23, 09:59
MfaProviderManifest.php:27I think this should stay. This implementation is only to be used by core.MfaProviderManifestInterface.php:23I think this should stay. This interface is only to be used by core.MfaProviderRegistry.php:25I think this should stay. The registry should not be used by extensions. -
core-ci voted on patch set 3 V +1 07/05/23, 10:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43481
-
Thomas Hohn uploaded patch set 4
V +107/05/23, 10:12 -
Thomas Hohn commented on patch set 4 07/05/23, 10:13
Reply
DoneMfaProviderManifest.php:27ReplyDoneMfaProviderManifestInterface.php:23ReplyDoneMfaProviderRegistry.php:25ReplyDone -
core-ci voted on patch set 4 V +1 07/05/23, 10:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43482
-
Oliver Klee voted on patch set 4 V +1 CR +1 07/05/23, 10:29
-
Oli Bartsch commented on patch set 4 07/05/23, 10:42
Reply
My intention was to backport this to v11 as well. -
Oli Bartsch updated the commit message in patch set 5
CR +1V +107/05/23, 10:42 -
Oli Bartsch commented on patch set 5 V +1 CR +1 07/05/23, 10:43
Reply
Done -
core-ci voted on patch set 5 V +1 07/05/23, 10:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43486
-
Andreas Kienast voted on patch set 5 V +1 CR +1 07/05/23, 10:56
-
Oli Bartsch voted on patch set 5 V +2 CR +2 07/05/23, 10:57
-
Oli Bartsch merged patch set 6 07/05/23, 10:57