Review main Merged

79712[TASK] Remove @internal for MfaProvider classes

Thomas Hohn CR +2 V +2 Easy +3 −9 updated 07/05/23, 10:57

Commit message

The following classes were marked as @internal in TYPO3 11 since
the feature was experimental. This should have been removed with
TYPO3 12. The @internal has now been removed for:
\TYPO3\CMS\Core\Authentication\Mfa\MfaProviderInterface
\TYPO3\CMS\Core\Authentication\Mfa\MfaProviderPropertyManager
\TYPO3\CMS\Core\Authentication\Mfa\MfaViewType

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 3

Files 6

Review log 1924

  1. Thomas Hohn uploaded patch set 1 07/05/23, 08:54

  2. Oliver Klee voted on patch set 1 V +1 CR +1 07/05/23, 08:54

  3. core-ci voted on patch set 1 V +1 07/05/23, 09:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43474

  4. Benni Mack commented on patch set 1 07/05/23, 09:16

    shouldn't they be removed in 12.4 then as well?
  5. Thomas Hohn commented on patch set 1 07/05/23, 09:17

    Reply

    We could do that too 😊
  6. Thomas Hohn updated the commit message in patch set 2 CR +1 V +1 07/05/23, 09:18

  7. core-ci voted on patch set 2 V +1 07/05/23, 09:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43478

  8. Benjamin Franzke voted on patch set 2 V +1 CR +1 07/05/23, 09:30

  9. Oliver Klee voted on patch set 2 V +1 CR +1 07/05/23, 09:31

  10. Oli Bartsch commented on patch set 2 07/05/23, 09:51

    Reply

    Actually this should have been removed with 11 LTS already. ;)
  11. Thomas Hohn uploaded patch set 3 CR +1 V +1 07/05/23, 09:57

  12. Oli Bartsch commented on patch set 3 07/05/23, 09:59

    MfaProviderManifest.php:27

    I think this should stay. This implementation is only to be used by core.

    MfaProviderManifestInterface.php:23

    I think this should stay. This interface is only to be used by core.

    MfaProviderRegistry.php:25

    I think this should stay. The registry should not be used by extensions.
  13. core-ci voted on patch set 3 V +1 07/05/23, 10:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43481

  14. Thomas Hohn uploaded patch set 4 V +1 07/05/23, 10:12

  15. Thomas Hohn commented on patch set 4 07/05/23, 10:13

    Reply

    Done

    MfaProviderManifest.php:27 Reply

    Done

    MfaProviderManifestInterface.php:23 Reply

    Done

    MfaProviderRegistry.php:25 Reply

    Done
  16. core-ci voted on patch set 4 V +1 07/05/23, 10:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43482

  17. Oliver Klee voted on patch set 4 V +1 CR +1 07/05/23, 10:29

  18. Oli Bartsch commented on patch set 4 07/05/23, 10:42

    Reply

    My intention was to backport this to v11 as well.
  19. Oli Bartsch updated the commit message in patch set 5 CR +1 V +1 07/05/23, 10:42

  20. Oli Bartsch commented on patch set 5 V +1 CR +1 07/05/23, 10:43

    Reply

    Done
  21. core-ci voted on patch set 5 V +1 07/05/23, 10:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43486

  22. Andreas Kienast voted on patch set 5 V +1 CR +1 07/05/23, 10:56

  23. Oli Bartsch voted on patch set 5 V +2 CR +2 07/05/23, 10:57

  24. Oli Bartsch merged patch set 6 07/05/23, 10:57