Review main Merged

79720[TASK] Use DI for mailer in backend PasswordReset

Torben Hansen CR +2 V +2 Easy +25 −10 updated 07/05/23, 14:39

Commit message

This patch injects `MailerInterface` in backend password reset using DI.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1418

  1. Torben Hansen uploaded patch set 1 07/05/23, 11:35

  2. Oliver Klee commented on patch set 1 07/05/23, 11:45

    Looks very good in general! I've added one remark concerning the tests.

    PasswordResetTest.php:56

    For stubs (i.e., mocks that do not have any expectations), I'd recommend `createStub` instead of `createMock` to communicate this more clearly. (Ditto for the other instances of `$mailerMock` in this change.)
  3. core-ci voted on patch set 1 V -1 07/05/23, 11:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43494

  4. Torben Hansen uploaded patch set 2 V -1 07/05/23, 12:04

  5. Torben Hansen commented on patch set 2 07/05/23, 12:04

    PasswordResetTest.php:56 Reply

    Done
  6. Oliver Klee commented on patch set 2 07/05/23, 12:07

    PasswordResetTest.php:142

    The logger should still use `createMock` as is has expectations (directly in the next line). Ditto in line 206.
  7. Torben Hansen uploaded patch set 3 07/05/23, 12:17

  8. Torben Hansen commented on patch set 2 07/05/23, 12:17

    PasswordResetTest.php:142 Reply

    Done
  9. core-ci voted on patch set 2 V -1 07/05/23, 12:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43501

  10. Benjamin Franzke commented on patch set 1 07/05/23, 12:19

    Services.yaml:40

    Why do you need `shared: false`. I don't see that PasswordReset has state, right?
  11. core-ci voted on patch set 3 V +1 07/05/23, 12:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43503

  12. Torben Hansen uploaded patch set 4 V +1 07/05/23, 12:36

  13. Torben Hansen commented on patch set 3 07/05/23, 12:37

    Services.yaml:40 Reply

    Yes, you`re right.
  14. core-ci voted on patch set 4 V +1 07/05/23, 12:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43507

  15. Oliver Klee commented on patch set 4 V +1 CR +1 07/05/23, 13:41

    Reply

    Done
  16. Benjamin Franzke voted on patch set 4 V +1 CR +1 07/05/23, 14:38

  17. Benjamin Franzke voted on patch set 4 V +2 CR +2 07/05/23, 14:38

  18. Benjamin Franzke merged patch set 5 07/05/23, 14:39