79724[BUGFIX] Fix checking of rootline in linkvalidator
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
-
Verified V +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 15
- typo3/sysext/linkvalidator/Classes/Repository/PagesRepository.php+1 −1
- typo3/sysext/linkvalidator/Tests/Functional/Repository/Fixtures/BrokenLinkRepositoryTest/be_groups.csvrenamed+0 −0
- typo3/sysext/linkvalidator/Tests/Functional/Repository/Fixtures/BrokenLinkRepositoryTest/be_users.csvrenamed+0 −0
- typo3/sysext/linkvalidator/Tests/Functional/Repository/Fixtures/BrokenLinkRepositoryTest/input.csvrenamed+0 −0
- typo3/sysext/linkvalidator/Tests/Functional/Repository/Fixtures/BrokenLinkRepositoryTest/input_languages.csvrenamed+0 −0
- typo3/sysext/linkvalidator/Tests/Functional/Repository/Fixtures/BrokenLinkRepositoryTest/input_permissions_group.csvrenamed+0 −0
- typo3/sysext/linkvalidator/Tests/Functional/Repository/Fixtures/BrokenLinkRepositoryTest/input_permissions_user_2.csvrenamed+0 −0
- typo3/sysext/linkvalidator/Tests/Functional/Repository/Fixtures/BrokenLinkRepositoryTest/input_permissions_user_3.csvrenamed+0 −0
- typo3/sysext/linkvalidator/Tests/Functional/Repository/Fixtures/BrokenLinkRepositoryTest/input_permissions_user_4.csvrenamed+0 −0
- typo3/sysext/linkvalidator/Tests/Functional/Repository/Fixtures/BrokenLinkRepositoryTest/input_permissions_user_5.csvrenamed+0 −0
- typo3/sysext/linkvalidator/Tests/Functional/Repository/Fixtures/BrokenLinkRepositoryTest/input_permissions_user_6_explicit_allow.csvrenamed+0 −0
- typo3/sysext/linkvalidator/Tests/Functional/Repository/Fixtures/PagesRepositoryTest/rootline_without_hidden_and_extendToSubpages.csvnew+6 −0
- typo3/sysext/linkvalidator/Tests/Functional/Repository/Fixtures/PagesRepositoryTest/rootline_with_hidden_and_extendToSubpages.csvnew+6 −0
- typo3/sysext/linkvalidator/Tests/Functional/Repository/BrokenLinkRepositoryTest.php+33 −33
- typo3/sysext/linkvalidator/Tests/Functional/Repository/PagesRepositoryTest.phpnew+60 −0
Review log 1219
-
Sybille Peters uploaded patch set 1 07/05/23, 13:10
-
core-ci voted on patch set 1 V -1 07/05/23, 13:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43516
-
Sybille Peters uploaded patch set 2
V -107/05/23, 13:53 -
core-ci voted on patch set 2 V -1 07/05/23, 14:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43524
-
Sybille Peters uploaded patch set 3
V -107/05/23, 14:29 -
core-ci voted on patch set 3 V -1 07/05/23, 14:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43532
-
Sybille Peters uploaded patch set 4
V -107/05/23, 15:09 -
core-ci voted on patch set 4 V +1 07/05/23, 15:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43543
-
Sybille Peters wrote 08/13/23, 09:17
Topic set to linkvalidator -
Sybille Peters uploaded patch set 5
V +108/13/23, 09:25 -
core-ci voted on patch set 5 V +1 08/13/23, 09:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45442
-
Oliver Klee updated the commit message in patch set 6
V +108/13/23, 09:42 -
core-ci voted on patch set 6 V +1 08/13/23, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45443
-
Sybille Peters rebased onto patch set 7
V +111/20/23, 12:23 -
core-ci voted on patch set 7 V +1 11/20/23, 12:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49126
-
Garvin Hicking commented on patch set 7 V +1 CR +1 11/21/23, 18:43
VERY nice catch! And good to have a test for this to secure future behaviour. I tried around with some other dummy fixtures and the link validator, and this looks good to me, thank you. 😊 -
Sybille Peters commented on patch set 7 11/21/23, 18:52
Reply
Thank you. -
Christian Kuhn voted on patch set 7 V +2 CR +2 11/21/23, 19:27
-
Christian Kuhn merged patch set 8 11/21/23, 19:27