Review main Merged

79724[BUGFIX] Fix checking of rootline in linkvalidator

Sybille Peters CR +2 V +2 Normal +106 −34 updated 11/21/23, 19:27

Commit message

The function `PagesRepository::doesRootLineContainHiddenPages`
did not correctly pass the pid if the function was called
recursively. This caused a premature termination of the
function.

This has now been fixed. In case a page has a page with "hidden"
and "extendToSubpages" set in any page in the rootline, this
function should now return true.

Additionally, some tests were added.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 15

Review log 1219

  1. Sybille Peters uploaded patch set 1 07/05/23, 13:10

  2. core-ci voted on patch set 1 V -1 07/05/23, 13:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43516

  3. Sybille Peters uploaded patch set 2 V -1 07/05/23, 13:53

  4. core-ci voted on patch set 2 V -1 07/05/23, 14:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43524

  5. Sybille Peters uploaded patch set 3 V -1 07/05/23, 14:29

  6. core-ci voted on patch set 3 V -1 07/05/23, 14:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43532

  7. Sybille Peters uploaded patch set 4 V -1 07/05/23, 15:09

  8. core-ci voted on patch set 4 V +1 07/05/23, 15:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43543

  9. Sybille Peters wrote 08/13/23, 09:17

    Topic set to linkvalidator
  10. Sybille Peters uploaded patch set 5 V +1 08/13/23, 09:25

  11. core-ci voted on patch set 5 V +1 08/13/23, 09:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45442

  12. Oliver Klee updated the commit message in patch set 6 V +1 08/13/23, 09:42

  13. core-ci voted on patch set 6 V +1 08/13/23, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45443

  14. Sybille Peters rebased onto patch set 7 V +1 11/20/23, 12:23

  15. core-ci voted on patch set 7 V +1 11/20/23, 12:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49126

  16. Garvin Hicking commented on patch set 7 V +1 CR +1 11/21/23, 18:43

    VERY nice catch! And good to have a test for this to secure future behaviour. I tried around with some other dummy fixtures and the link validator, and this looks good to me, thank you. 😊
  17. Sybille Peters commented on patch set 7 11/21/23, 18:52

    Reply

    Thank you.
  18. Christian Kuhn voted on patch set 7 V +2 CR +2 11/21/23, 19:27

  19. Christian Kuhn merged patch set 8 11/21/23, 19:27