Review main Merged

79726[TASK] Remove jQuery from TcaMigrationsCheck

Oli Bartsch CR +2 V +2 Easy +25 −25 updated 07/05/23, 17:22

Commit message

Additionally, the handleAjaxRequest function
of the install tool router now also allows
a HTMLElement to be passed as second argument.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • Jochen Roth +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 89

  1. Oli Bartsch uploaded patch set 1 07/05/23, 14:23

  2. core-ci voted on patch set 1 V +1 07/05/23, 14:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43531

  3. Benjamin Franzke commented on patch set 1 07/05/23, 14:55

    tca-migrations-check.ts:40

    no delegate please
  4. Benjamin Franzke commented on patch set 1 07/05/23, 15:20

    tca-migrations-check.ts:40 Reply

    sorry, my fault, was a delegate before.
  5. Oli Bartsch commented on patch set 1 07/05/23, 15:20

    tca-migrations-check.ts:40 Reply

    Unfortunately, bindTo() does not work here due to timing issues with the modal content.
  6. Benjamin Franzke voted on patch set 1 V +1 CR +1 07/05/23, 15:21

  7. Jochen Roth voted on patch set 1 V +1 CR +1 07/05/23, 15:33

  8. Oli Bartsch voted on patch set 1 V +2 CR +2 07/05/23, 17:22

  9. Oli Bartsch merged patch set 2 07/05/23, 17:22