Review main Merged

79756[BUGFIX] Normalize filename of uploaded files

Oliver Hader CR +2 V +2 Easy +20 −3 updated 07/06/23, 18:33

Commit message

The filename of uploaded files might not be encoded
as normalized unicode. For instance, this happens when
using umlauts in filenames on HFS+ filesystem (macOS).

For instance the client sends an `ö`, which is sent in
NFD as `0x6fcc88`, but should be normalized as `0xc3b6`.

https://en.wikipedia.org/wiki/Unicode_equivalence#Normalization

Executed commands:
composer req symfony/polyfill-intl-normalizer:^1.27
composer req symfony/polyfill-intl-normalizer:^1.27 \
    -d typo3/sysext/core --no-update

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Markus Klein +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Markus Klein +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1013

  1. Oliver Hader uploaded patch set 1 07/05/23, 17:46

  2. core-ci voted on patch set 1 V -1 07/05/23, 17:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43573

  3. Oliver Hader uploaded patch set 2 V -1 07/05/23, 18:18

  4. core-ci voted on patch set 2 V +1 07/05/23, 18:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43580

  5. Torben Hansen voted on patch set 1 V +1 CR +1 07/05/23, 19:04

  6. Torben Hansen voted on patch set 2 V +1 CR +1 07/05/23, 19:33

  7. Markus Klein voted on patch set 2 V +1 CR +1 07/05/23, 20:04

  8. Oliver Hader uploaded patch set 3 CR +1 V +1 07/06/23, 09:33

  9. core-ci voted on patch set 3 V +1 07/06/23, 11:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43677

  10. Benni Mack voted on patch set 3 V +1 CR +1 07/06/23, 18:02

  11. Markus Klein voted on patch set 3 V +1 CR +1 07/06/23, 18:21

  12. Oliver Hader voted on patch set 3 V +2 CR +2 07/06/23, 18:33

  13. Oliver Hader merged patch set 4 07/06/23, 18:33