Review main Merged

79759[BUGFIX] Set column width for table grids in page module

Benjamin Kott CR +2 V +2 Easy +38 −9 updated 07/06/23, 17:31

Commit message

The backend layout representation in the backend implements a table
based layout. While the columns spanning was interpreted correctly,
the definition of how wide a column is in the defined grid was missing,
causing the cells to take up an unexpected amount of space.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Annett Jähnichen +1
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 4

Files 6

Review log 1520

  1. Benjamin Kott uploaded patch set 1 07/05/23, 20:49

  2. core-ci voted on patch set 1 V -1 07/05/23, 21:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43628

  3. Jasmina Ließmann commented on patch set 1 07/05/23, 21:33

    BackendLayout.php:203

    Should be 'rowCount'?
  4. Benjamin Kott uploaded patch set 2 V -1 07/06/23, 08:30

  5. Benjamin Kott commented on patch set 2 07/06/23, 08:30

    BackendLayout.php:203 Reply

    yes, was copy pasta ;)
  6. core-ci voted on patch set 2 V +1 07/06/23, 08:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43668

  7. Georg Ringer voted on patch set 2 V +1 CR +1 07/06/23, 09:26

  8. Annett Jähnichen commented on patch set 2 V -1 07/06/23, 10:19

    Unused content in a page with 4 cols is shown reduced to one column. Can we display these at full width?
  9. Benjamin Kott uploaded patch set 3 CR +1 V +1 07/06/23, 11:33

  10. Benjamin Kott commented on patch set 3 07/06/23, 11:34

    Reply

    good catch did not see that the view is not resetted.
  11. Annett Jähnichen commented on patch set 3 V +1 07/06/23, 11:42

    Reply

    Looks good now.
  12. core-ci voted on patch set 3 V -1 07/06/23, 11:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43706

  13. core-ci commented on patch set 3 07/06/23, 13:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43706

  14. Andreas Kienast uploaded patch set 4 V +1 07/06/23, 14:23

  15. core-ci voted on patch set 4 V +1 07/06/23, 14:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43755

  16. Annett Jähnichen voted on patch set 4 V +1 07/06/23, 14:35

  17. Benni Mack voted on patch set 4 V +1 CR +1 07/06/23, 17:07

  18. Jochen Roth voted on patch set 4 V +1 CR +1 07/06/23, 17:28

  19. Benjamin Kott voted on patch set 4 V +2 CR +2 07/06/23, 17:31

  20. Benjamin Kott merged patch set 5 07/06/23, 17:31