79759[BUGFIX] Set column width for table grids in page module
Commit message
Review
-
Code review CR +2 Done
- Benjamin Kott +2
- Jochen Roth +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Kott +2
- Annett Jähnichen +1
- Jochen Roth +1
- Benni Mack +1
- core-ci +1 CI
Issues 4
Files 6
- Build/Sources/Sass/module/_page.scss+12 −5
- typo3/sysext/backend/Classes/View/BackendLayout/BackendLayout.php2+10 −0
- typo3/sysext/backend/Classes/View/Drawing/BackendLayoutRenderer.php+4 −1
- typo3/sysext/backend/Classes/View/BackendLayoutView.php+2 −0
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/Grid.html+7 −0
- typo3/sysext/backend/Resources/Public/Css/backend.css+3 −3
Review log 1520
-
Benjamin Kott uploaded patch set 1 07/05/23, 20:49
-
core-ci voted on patch set 1 V -1 07/05/23, 21:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43628
-
Jasmina Ließmann commented on patch set 1 07/05/23, 21:33
-
Benjamin Kott uploaded patch set 2
V -107/06/23, 08:30 -
Benjamin Kott commented on patch set 2 07/06/23, 08:30
BackendLayout.php:203Replyyes, was copy pasta ;) -
core-ci voted on patch set 2 V +1 07/06/23, 08:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43668
-
Georg Ringer voted on patch set 2 V +1 CR +1 07/06/23, 09:26
-
Annett Jähnichen commented on patch set 2 V -1 07/06/23, 10:19
Unused content in a page with 4 cols is shown reduced to one column. Can we display these at full width? -
Benjamin Kott uploaded patch set 3
CR +1V +107/06/23, 11:33 -
Benjamin Kott commented on patch set 3 07/06/23, 11:34
Reply
good catch did not see that the view is not resetted. -
Annett Jähnichen commented on patch set 3 V +1 07/06/23, 11:42
Reply
Looks good now. -
core-ci voted on patch set 3 V -1 07/06/23, 11:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43706
-
core-ci commented on patch set 3 07/06/23, 13:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43706
-
Andreas Kienast uploaded patch set 4
V +107/06/23, 14:23 -
core-ci voted on patch set 4 V +1 07/06/23, 14:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43755
-
Annett Jähnichen voted on patch set 4 V +1 07/06/23, 14:35
-
Benni Mack voted on patch set 4 V +1 CR +1 07/06/23, 17:07
-
Jochen Roth voted on patch set 4 V +1 CR +1 07/06/23, 17:28
-
Benjamin Kott voted on patch set 4 V +2 CR +2 07/06/23, 17:31
-
Benjamin Kott merged patch set 5 07/06/23, 17:31
BackendLayout.php:203