79792[BUGFIX] Set default plugin title if no label was set
Commit message
Review
-
Code review CR +2 Done
- Annett Jähnichen +2
- Oli Bartsch +1
- Susi Moog +1
-
Verified V +2 Done
- Annett Jähnichen +2
- Oli Bartsch +1
- Susi Moog +1
Issues 1
Files 1
Review log 1723
-
Annett Jähnichen uploaded patch set 1 07/06/23, 09:49
-
Sybille Peters updated the commit message in patch set 2 07/06/23, 10:14
-
Sybille Peters commented on patch set 2 07/06/23, 10:14
Minor nitpick: would always start commit message with capital letter (see previous commit messages): https://github.com/TYPO3/typo3/commits/main -
Sybille Peters commented on patch set 2 07/06/23, 10:17
ExtensionUtility.php:130$pluginTitle is only set to $pluginName here if $pluginName is empty. Do we really want that? Maybe I misunderstood something. -
Annett Jähnichen uploaded patch set 3 07/06/23, 10:23
-
core-ci voted on patch set 2 V -1 07/06/23, 10:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43681
-
core-ci voted on patch set 3 V -1 07/06/23, 10:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43686
-
Annett Jähnichen uploaded patch set 4
V -107/06/23, 10:49 -
Annett Jähnichen commented on patch set 4 07/06/23, 10:51
ExtensionUtility.php:130ReplySorry no, we want to check if only pluginTitle is not set. -
core-ci voted on patch set 4 V +1 07/06/23, 11:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43697
-
Annett Jähnichen uploaded patch set 5
V +107/06/23, 12:16 -
Susi Moog voted on patch set 5 V +1 CR +1 07/06/23, 12:25
-
core-ci voted on patch set 5 V +1 07/06/23, 12:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43723
-
Andreas Kienast commented on patch set 5 07/06/23, 14:20
ExtensionUtility.php:130This condition is superfluous, `$pluginTitle === ''` already ensures it's not null. -
Annett Jähnichen uploaded patch set 6
CR +1V +107/06/23, 17:48 -
Annett Jähnichen commented on patch set 6 07/06/23, 17:49
ExtensionUtility.php:130ReplyDone -
core-ci voted on patch set 6 V +1 07/06/23, 17:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43789
-
Oli Bartsch updated the commit message in patch set 7
V +107/06/23, 18:02 -
Oli Bartsch commented on patch set 7 V +1 CR +1 07/06/23, 18:02
ExtensionUtility.php:130ReplyDone -
Susi Moog voted on patch set 7 V +1 CR +1 07/06/23, 18:08
-
Annett Jähnichen voted on patch set 7 V +2 CR +2 07/06/23, 18:08
-
Annett Jähnichen merged patch set 8 07/06/23, 18:09
-
core-ci voted on patch set 7 V +1 07/06/23, 18:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43792