Review main Merged

79792[BUGFIX] Set default plugin title if no label was set

Annett Jähnichen CR +2 V +2 Easy +5 −0 updated 07/06/23, 18:13

Commit message

If the pluginTitle wasn't set, a warning message was rendered
in the page module as if the plugin wasn't configured.
We now use the PluginName as default to create
a visual difference between a plugin that is not configured.

Review

  • Code review CR +2 Done
    • Annett Jähnichen +2
    • Oli Bartsch +1
    • Susi Moog +1
  • Verified V +2 Done
    • Annett Jähnichen +2
    • Oli Bartsch +1
    • Susi Moog +1

Issues 1

Files 1

Review log 1723

  1. Annett Jähnichen uploaded patch set 1 07/06/23, 09:49

  2. Sybille Peters updated the commit message in patch set 2 07/06/23, 10:14

  3. Sybille Peters commented on patch set 2 07/06/23, 10:14

    Minor nitpick: would always start commit message with capital letter (see previous commit messages): https://github.com/TYPO3/typo3/commits/main
  4. Sybille Peters commented on patch set 2 07/06/23, 10:17

    ExtensionUtility.php:130

    $pluginTitle is only set to $pluginName here if $pluginName is empty. Do we really want that? Maybe I misunderstood something.
  5. Annett Jähnichen uploaded patch set 3 07/06/23, 10:23

  6. core-ci voted on patch set 2 V -1 07/06/23, 10:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43681

  7. core-ci voted on patch set 3 V -1 07/06/23, 10:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43686

  8. Annett Jähnichen uploaded patch set 4 V -1 07/06/23, 10:49

  9. Annett Jähnichen commented on patch set 4 07/06/23, 10:51

    ExtensionUtility.php:130 Reply

    Sorry no, we want to check if only pluginTitle is not set.
  10. core-ci voted on patch set 4 V +1 07/06/23, 11:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43697

  11. Annett Jähnichen uploaded patch set 5 V +1 07/06/23, 12:16

  12. Susi Moog voted on patch set 5 V +1 CR +1 07/06/23, 12:25

  13. core-ci voted on patch set 5 V +1 07/06/23, 12:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43723

  14. Andreas Kienast commented on patch set 5 07/06/23, 14:20

    ExtensionUtility.php:130

    This condition is superfluous, `$pluginTitle === ''` already ensures it's not null.
  15. Annett Jähnichen uploaded patch set 6 CR +1 V +1 07/06/23, 17:48

  16. Annett Jähnichen commented on patch set 6 07/06/23, 17:49

    ExtensionUtility.php:130 Reply

    Done
  17. core-ci voted on patch set 6 V +1 07/06/23, 17:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43789

  18. Oli Bartsch updated the commit message in patch set 7 V +1 07/06/23, 18:02

  19. Oli Bartsch commented on patch set 7 V +1 CR +1 07/06/23, 18:02

    ExtensionUtility.php:130 Reply

    Done
  20. Susi Moog voted on patch set 7 V +1 CR +1 07/06/23, 18:08

  21. Annett Jähnichen voted on patch set 7 V +2 CR +2 07/06/23, 18:08

  22. Annett Jähnichen merged patch set 8 07/06/23, 18:09

  23. core-ci voted on patch set 7 V +1 07/06/23, 18:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43792