Review main Merged

79793[BUGFIX] Accept "00:00 01-01-1970" in FormEngine UI

Andreas Kienast CR +2 V +2 Easy +24 −11 updated 07/06/23, 12:37

Commit message

The FormEngine validation now accepts "00:00 01-01-1970" as an entered
date, which evaluates to int 0. If string 0 is passed, the field is
supposed to be empty. Previously, a too simple negation check was in
place.

In the long run, the whole date validation handling needs a major
rewrite to not rely on timestamps anymore.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Markus Klein +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Markus Klein +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 56

  1. Andreas Kienast uploaded patch set 1 07/06/23, 10:21

  2. core-ci voted on patch set 1 V +1 07/06/23, 10:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43685

  3. Benni Mack commented on patch set 1 V +1 CR +1 07/06/23, 11:46

    This is also now properly persisted in nullable date fields, but not on regular date/time fields
  4. Markus Klein voted on patch set 1 V +1 CR +1 07/06/23, 12:17

  5. Andreas Kienast voted on patch set 1 V +2 CR +2 07/06/23, 12:37

  6. Andreas Kienast merged patch set 2 07/06/23, 12:37