Review main Merged

79794[BUGFIX] Dispatch event on failed mfa attempt

Oli Bartsch CR +2 V +2 Normal +135 −24 updated 07/06/23, 12:09

Commit message

By dispatching a new PSR-14 Event on a failed
multi-factor authentication attempt, it's now
possible to consider such failed attempts in
the "send email on failed login" functionality.

The improved log message does now also use the
correct "action" and "error" types, which allows
further functionality, such as the corresponding
dashboard widget, to make use of those information.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 911

  1. Oli Bartsch uploaded patch set 1 07/06/23, 10:27

  2. Oli Bartsch uploaded patch set 2 07/06/23, 10:32

  3. Oli Bartsch uploaded patch set 3 07/06/23, 10:37

  4. core-ci voted on patch set 3 V -1 07/06/23, 11:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43693

  5. Oli Bartsch uploaded patch set 4 V -1 07/06/23, 11:20

  6. core-ci voted on patch set 4 V +1 07/06/23, 11:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43701

  7. Jochen Roth voted on patch set 4 V +1 CR +1 07/06/23, 11:43

  8. Benjamin Franzke voted on patch set 4 CR +1 07/06/23, 11:59

  9. Benni Mack voted on patch set 4 V +1 CR +1 07/06/23, 12:00

  10. Oli Bartsch voted on patch set 4 V +2 CR +2 07/06/23, 12:09

  11. Oli Bartsch merged patch set 5 07/06/23, 12:09