Review main Abandoned Breaking

79797[!!!][TASK] Remove `FormPersistenceManagerInterface` from EXT:form

Andreas Kienast CR 0 V 0 Normal +58 −110 updated 07/06/23, 16:07

Commit message

The `form` extension has an interface
`\TYPO3\CMS\Form\Mvc\Persistence\FormPersistenceManagerInterface` that
has been removed as it was implemented only once and doesn't seem to
serve a greater good.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 11

Review log 1114

  1. Andreas Kienast uploaded patch set 1 07/06/23, 10:53

  2. core-ci voted on patch set 1 V -1 07/06/23, 11:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43700

  3. Benni Mack uploaded patch set 2 V -1 07/06/23, 11:22

  4. Benni Mack voted on patch set 2 V +1 CR +1 07/06/23, 11:22

  5. Christian Kuhn commented on patch set 1 07/06/23, 11:23

    Maybe reconsider: The interface can be handy when FormPersistenceManager has to be mocked in tests: It allows setting FormPersistenceManager final and use FormPersistenceManagerInterface as mock. Or isn't this a valid use case?
  6. Christian Kuhn voted on patch set 2 CR -1 07/06/23, 11:23

  7. Benni Mack commented on patch set 2 07/06/23, 11:27

    Reply

    I agree, however that's the only use-case really. Currently the few places where EXT:form is actually *using* the interface just shows how bad the implementation is. We're trying to continue efforts in cleaning up the extension and instead of "breaking" this interface (probably multiple times) we can just drop it. I think there are even more concepts that are just not properly used since v8, and never continued.
  8. core-ci voted on patch set 2 V -1 07/06/23, 11:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43702

  9. Christian Kuhn commented on patch set 2 CR 0 07/06/23, 14:38

    To not block development, and since this area is not crucial (to me), I'll remove -1. You could still consider to simply adapt the interface as needed and just have a .rst file saying "it changed". This would allow further changes within v13 as well. However, if you think removal is more suitable in this case, then go for it. I won't be suprprised if the interface is added again later again, though, but that may also take quite some time.
  10. Andreas Kienast uploaded patch set 3 CR +1 V +1 07/06/23, 14:39

  11. Benni Mack commented on patch set 3 07/06/23, 14:39

    we don't mind either :) - Andy just found a unnamed breaking change in a feature ;) https://review.typo3.org/c/Packages/TYPO3.CMS/+/74924
  12. Benni Mack voted on patch set 3 V +1 CR +1 07/06/23, 14:43

  13. core-ci voted on patch set 3 V -1 07/06/23, 14:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43761

  14. Benni Mack abandoned the change 07/06/23, 16:07