Review main Merged Breaking

79809[!!!][TASK] Remove RequireJS

Benjamin Franzke CR +2 V +2 Hard +140 −730 updated 07/07/23, 08:18

Commit message

RequireJS has been replaced by ECMAScript v6/v11
modules and is now removed.

Support for RequireJS in FormEngine has already been
partially removed in #101067.
This patch removes the backing infrastructure from PageRenderer
and adapts RSTs to document all removed methods
(like PageRenderer->loadRequireJsModule) from both patches.

Executed commands:

npm remove requirejs @types/requirejs
grunt build

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 5

Files 28

Show 8 more files

Review log 1218

  1. Benjamin Franzke uploaded patch set 1 07/06/23, 14:32

  2. core-ci voted on patch set 1 V -1 07/06/23, 14:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43759

  3. Benjamin Franzke uploaded patch set 2 V -1 07/06/23, 14:55

  4. core-ci voted on patch set 2 V -1 07/06/23, 15:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43762

  5. Benjamin Franzke uploaded patch set 3 V -1 07/06/23, 15:16

  6. core-ci voted on patch set 3 V -1 07/06/23, 15:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43764

  7. Benjamin Franzke uploaded patch set 4 V -1 07/06/23, 15:53

  8. core-ci voted on patch set 4 V +1 07/06/23, 16:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43770

  9. Benni Mack uploaded patch set 5 V +1 07/06/23, 17:31

  10. core-ci voted on patch set 5 V +1 07/06/23, 17:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43783

  11. Benjamin Franzke uploaded patch set 6 V +1 07/07/23, 07:41

  12. Benjamin Franzke wrote 07/07/23, 07:41

    Topic set to esm
  13. Benjamin Franzke updated the commit message in patch set 7 07/07/23, 07:42

  14. Andreas Kienast commented on patch set 7 V +1 CR +1 07/07/23, 07:51

    🫡
  15. core-ci voted on patch set 7 V +1 07/07/23, 07:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43857

  16. Oli Bartsch commented on patch set 7 V +1 CR +1 07/07/23, 08:16

    :wave:
  17. Benjamin Franzke voted on patch set 7 V +2 CR +2 07/07/23, 08:18

  18. Benjamin Franzke merged patch set 8 07/07/23, 08:18