Review main Merged

79835[TASK] Extract Indexed Search inline event handling

Oliver Hader CR +2 V +2 Normal +67 −9 updated 07/07/23, 08:11

Commit message

Indexed Search pagination still uses `onclick="..."` inline
event handlers. For being compatible with content security policy,
the corresponding handlers are added as inline JavaScript, embedded
with a CSP nonce value.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Susi Moog +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Susi Moog +1

Issues 1

Files 2

Review log 1215

  1. Oliver Hader uploaded patch set 1 07/06/23, 17:40

  2. Benni Mack commented on patch set 1 07/06/23, 17:43

    PageBrowsingViewHelper.php:156

    please dont
  3. core-ci voted on patch set 1 V -1 07/06/23, 17:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43787

  4. Oliver Hader uploaded patch set 2 V -1 07/06/23, 18:10

  5. core-ci voted on patch set 2 V +1 07/06/23, 18:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43795

  6. Benni Mack commented on patch set 2 CR +1 07/06/23, 19:07

    PageBrowsingViewHelper.php:156 Reply

    Done
  7. Susi Moog voted on patch set 2 V +1 CR +1 07/07/23, 07:50

  8. Stefan Bürk voted on patch set 2 V +1 CR +1 07/07/23, 07:51

  9. Andreas Kienast commented on patch set 2 CR -1 07/07/23, 07:57

    PageBrowsingViewHelper.php:135 Unresolved

    `$onclick` is now unused.
  10. Andreas Kienast uploaded patch set 3 CR +1 V +1 07/07/23, 08:02

  11. Andreas Kienast voted on patch set 3 V +1 CR +1 07/07/23, 08:03

  12. Susi Moog voted on patch set 3 V +1 CR +1 07/07/23, 08:10

  13. Andreas Kienast voted on patch set 3 V +2 CR +2 07/07/23, 08:10

  14. Andreas Kienast merged patch set 4 07/07/23, 08:10

  15. core-ci voted on patch set 3 V +1 07/07/23, 08:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43860