Review 12.4 Merged

79837[BUGFIX] Normalize filename of uploaded files

Oliver Hader CR +2 V +2 Easy +20 −3 updated 07/06/23, 18:34

Commit message

The filename of uploaded files might not be encoded
as normalized unicode. For instance, this happens when
using umlauts in filenames on HFS+ filesystem (macOS).

For instance the client sends an `ö`, which is sent in
NFD as `0x6fcc88`, but should be normalized as `0xc3b6`.

https://en.wikipedia.org/wiki/Unicode_equivalence#Normalization

Executed commands:
composer req symfony/polyfill-intl-normalizer:^1.27
composer req symfony/polyfill-intl-normalizer:^1.27 \
    -d typo3/sysext/core --no-update

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 7

Review log 34

  1. Oliver Hader uploaded patch set 1 07/06/23, 18:12

  2. core-ci voted on patch set 1 V +1 07/06/23, 18:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43796

  3. Oliver Hader voted on patch set 1 V +2 CR +2 07/06/23, 18:34

  4. Oliver Hader merged patch set 2 07/06/23, 18:34