Review main Merged

79839[TASK] Remove unused information from ClassSchema

Alexander Schnitzler CR +2 V +2 Hard +2 −590 updated 07/07/23, 12:22

Commit message

Information that is not needed does not need to be
gathered. It saves both CPU cycles and memory and reduces
the amount of cached data.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Susi Moog +1
    • core-ci +1 CI

Issues 1

Files 19

Review log 1824

  1. Alexander Schnitzler uploaded patch set 1 07/06/23, 18:24

  2. Alexander Schnitzler wrote 07/06/23, 18:24

    Topic set to extbase
  3. Alexander Schnitzler uploaded patch set 2 07/06/23, 18:44

  4. core-ci voted on patch set 1 V +1 07/06/23, 18:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43802

  5. Alexander Schnitzler commented on patch set 2 07/06/23, 18:45

    This change is ready for review.
  6. core-ci voted on patch set 2 V +1 07/06/23, 18:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43807

  7. Oliver Klee voted on patch set 2 V +1 07/06/23, 18:54

  8. Alexander Schnitzler uploaded patch set 3 V +1 07/06/23, 18:58

  9. Oliver Klee commented on patch set 2 V +1 07/06/23, 18:59

    MethodParameterTest.php:201

    I’d like to propose a name change so that the test method name contains a statement about the expected behavior: ``` isArrayForArrayParameterReturnsTrue ``` I’d also like to propose those tests for isArray: - isArrayForSingleTypeNonArrayParameterReturnsFalse (e.g., for `string`) - a test for a union type with an array - a test for an intersection type with an array What do you think?
  10. core-ci voted on patch set 3 V +1 07/06/23, 19:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43808

  11. Oliver Klee commented on patch set 3 07/06/23, 19:10

    MethodParameterTest.php:201 Reply

    Or should we move adding new tests for`isArray` to a separate ticket + change?
  12. Alexander Schnitzler commented on patch set 3 07/06/23, 19:11

    MethodParameterTest.php:201 Reply

    > ’d like to propose a name change so that the test method name contains a > statement about the expected behavior: That's ok for me. But as you mention intersection types and so on I wonder if we should rather keep the old behaviour in this area and tackle this case independently because it's the only code I changed that is not unused but duplicated. I think it makes sense to cover the original behaviour with tests before changing the implementation. So what I would do now is to revert the changes in this area.
  13. Oliver Klee commented on patch set 3 07/06/23, 19:13

    MethodParameterTest.php:201 Reply

    Sounds good to me.
  14. Alexander Schnitzler uploaded patch set 4 V +1 07/06/23, 19:16

  15. Alexander Schnitzler commented on patch set 4 07/06/23, 19:17

    MethodParameterTest.php:201 Reply

    Done
  16. Alexander Schnitzler uploaded patch set 5 07/06/23, 19:18

  17. core-ci voted on patch set 5 V +1 07/06/23, 19:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43813

  18. core-ci voted on patch set 4 V +1 07/06/23, 19:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43812

  19. Oliver Klee updated the commit message in patch set 6 V +1 07/06/23, 19:45

  20. Oliver Klee voted on patch set 6 V +1 07/06/23, 19:45

  21. core-ci voted on patch set 6 V +1 07/06/23, 19:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43817

  22. Susi Moog voted on patch set 6 V +1 CR +1 07/07/23, 10:54

  23. Benni Mack voted on patch set 6 V +2 CR +2 07/07/23, 12:22

  24. Benni Mack merged patch set 7 07/07/23, 12:22