79839[TASK] Remove unused information from ClassSchema
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Susi Moog +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- Susi Moog +1
- core-ci +1 CI
Issues 1
Files 19
- Build/phpstan/phpstan-baseline.neon+0 −15
- typo3/sysext/extbase/Classes/Reflection/ClassSchema/Method.php+0 −31
- typo3/sysext/extbase/Classes/Reflection/ClassSchema/MethodParameter.php+0 −6
- typo3/sysext/extbase/Classes/Reflection/ClassSchema/Property.php+0 −9
- typo3/sysext/extbase/Classes/Reflection/ClassSchema/PropertyCharacteristics.php+0 −1
- typo3/sysext/extbase/Classes/Reflection/ClassSchema.php+2 −116
- typo3/sysext/extbase/Tests/Unit/Reflection/ClassSchema/MethodTest.php+0 −12
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyClassWithAllTypesOfMethods.php+0 −38
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyClassWithAllTypesOfProperties.php+0 −13
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyClassWithConstructorAndConstructorArguments.phpdeleted+0 −28
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyClassWithConstructorAndConstructorArgumentsWithDependencies.phpdeleted+0 −28
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyClassWithConstructorAndWithoutConstructorArguments.phpdeleted+0 −28
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyClassWithoutConstructor.phpdeleted+0 −25
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyClassWithTags.phpdeleted+0 −32
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyEntity.phpdeleted+0 −27
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyModelRepository.phpdeleted+0 −27
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummySingleton.phpdeleted+0 −27
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyValueObject.phpdeleted+0 −27
- typo3/sysext/extbase/Tests/Unit/Reflection/ClassSchemaTest.php+0 −100
Review log 1824
-
Alexander Schnitzler uploaded patch set 1 07/06/23, 18:24
-
Alexander Schnitzler wrote 07/06/23, 18:24
Topic set to extbase -
Alexander Schnitzler uploaded patch set 2 07/06/23, 18:44
-
core-ci voted on patch set 1 V +1 07/06/23, 18:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43802
-
Alexander Schnitzler commented on patch set 2 07/06/23, 18:45
This change is ready for review. -
core-ci voted on patch set 2 V +1 07/06/23, 18:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43807
-
Oliver Klee voted on patch set 2 V +1 07/06/23, 18:54
-
Alexander Schnitzler uploaded patch set 3
V +107/06/23, 18:58 -
Oliver Klee commented on patch set 2 V +1 07/06/23, 18:59
MethodParameterTest.php:201I’d like to propose a name change so that the test method name contains a statement about the expected behavior: ``` isArrayForArrayParameterReturnsTrue ``` I’d also like to propose those tests for isArray: - isArrayForSingleTypeNonArrayParameterReturnsFalse (e.g., for `string`) - a test for a union type with an array - a test for an intersection type with an array What do you think? -
core-ci voted on patch set 3 V +1 07/06/23, 19:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43808
-
Oliver Klee commented on patch set 3 07/06/23, 19:10
MethodParameterTest.php:201ReplyOr should we move adding new tests for`isArray` to a separate ticket + change? -
Alexander Schnitzler commented on patch set 3 07/06/23, 19:11
MethodParameterTest.php:201Reply> ’d like to propose a name change so that the test method name contains a > statement about the expected behavior: That's ok for me. But as you mention intersection types and so on I wonder if we should rather keep the old behaviour in this area and tackle this case independently because it's the only code I changed that is not unused but duplicated. I think it makes sense to cover the original behaviour with tests before changing the implementation. So what I would do now is to revert the changes in this area. -
Oliver Klee commented on patch set 3 07/06/23, 19:13
MethodParameterTest.php:201ReplySounds good to me. -
Alexander Schnitzler uploaded patch set 4
V +107/06/23, 19:16 -
Alexander Schnitzler commented on patch set 4 07/06/23, 19:17
MethodParameterTest.php:201ReplyDone -
Alexander Schnitzler uploaded patch set 5 07/06/23, 19:18
-
core-ci voted on patch set 5 V +1 07/06/23, 19:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43813
-
core-ci voted on patch set 4 V +1 07/06/23, 19:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43812
-
Oliver Klee updated the commit message in patch set 6
V +107/06/23, 19:45 -
Oliver Klee voted on patch set 6 V +1 07/06/23, 19:45
-
core-ci voted on patch set 6 V +1 07/06/23, 19:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43817
-
Susi Moog voted on patch set 6 V +1 CR +1 07/07/23, 10:54
-
Benni Mack voted on patch set 6 V +2 CR +2 07/07/23, 12:22
-
Benni Mack merged patch set 7 07/07/23, 12:22