Review 12.4 Merged

79865[BUGFIX] Fix command detection with open_basedir in effect

Benni Mack CR +2 V +2 Normal +30 −29 updated 07/07/23, 14:23

Commit message

When `open_basedir` is set (often the case on shared hosting), TYPO3
fails to find executables as it does a check for file existence first,
which fails due to the restriction.

Instead of checking file existence in all cases, a fallback has been
added on *nix systems that will try execution of a given command
and use the return code to decide whether the path is valid.

This itself uses the command `which` which is not available on Windows.
As nowadays `open_basedir` is mostly used on shared hosting
environments based on *nix, this will not be fixed for Windows.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 2

Files 3

Review log 34

  1. Benni Mack commented on patch set 1 07/07/23, 13:42

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 07/07/23, 13:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43916

  3. Benni Mack voted on patch set 1 V +2 CR +2 07/07/23, 14:23

  4. Benni Mack merged patch set 2 07/07/23, 14:23