Review main Merged

79872[BUGFIX] Display field labels of FormEngine container elements

Oli Bartsch CR +2 V +2 Normal +32 −76 updated 07/07/23, 11:03

Commit message

Since #97330, field labels are explicitly added
in the corresponding elements and are no longer
added at a central place. However, there are also
"container elements" (e.g. "inline, or "file"),
which now need to handle rendering of their
label manually, too.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Annett Jähnichen +1
    • Jochen Roth +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Annett Jähnichen +1
    • Jochen Roth +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 15

Review log 1418

  1. Oli Bartsch uploaded patch set 1 07/07/23, 08:16

  2. core-ci voted on patch set 1 V -1 07/07/23, 08:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43866

  3. Annett Jähnichen voted on patch set 1 V +1 07/07/23, 08:37

  4. Oli Bartsch rebased onto patch set 2 V +1 07/07/23, 08:41

  5. core-ci voted on patch set 2 V -1 07/07/23, 09:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43870

  6. Oli Bartsch uploaded patch set 3 V -1 07/07/23, 09:18

  7. core-ci voted on patch set 3 V +1 07/07/23, 09:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43876

  8. Annett Jähnichen voted on patch set 3 V +1 07/07/23, 09:29

  9. Annett Jähnichen voted on patch set 3 CR +1 07/07/23, 09:39

  10. Jochen Roth voted on patch set 3 V +1 CR +1 07/07/23, 10:16

  11. Andreas Kienast voted on patch set 3 V +1 CR +1 07/07/23, 10:36

  12. Oli Bartsch updated the commit message in patch set 4 CR +1 V +1 07/07/23, 10:50

  13. Andreas Kienast voted on patch set 4 V +1 CR +1 07/07/23, 10:50

  14. Annett Jähnichen voted on patch set 4 V +1 CR +1 07/07/23, 10:50

  15. Jochen Roth voted on patch set 4 V +1 CR +1 07/07/23, 10:52

  16. core-ci voted on patch set 4 V +1 07/07/23, 10:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43886

  17. Oli Bartsch voted on patch set 4 V +2 CR +2 07/07/23, 11:03

  18. Oli Bartsch merged patch set 5 07/07/23, 11:03