Review 11.5 Abandoned

79879[BUGFIX] Allow 1970-01-01 as native datetime input

JAKOTA Design Group GmbH CR 0 V 0 Normal +166 −28 updated 07/08/23, 15:08

Commit message

The TCA processing temporary converts native datetime inputs to
timestamps for some checks.
The start of the unix epoch (1970-01-01 00:00) corresponds to the
0 timestamp. Conditionally checks interpreted that as false,
resulting the value to be the default value.
This fix also prevents empty date values from being set to
MySQL-specific values (0000-00-00 00:00:00).

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 4

Review log 1217

  1. JAKOTA Design Group GmbH uploaded patch set 1 07/08/23, 03:03

  2. core-ci voted on patch set 1 V -1 07/08/23, 03:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43934

  3. JAKOTA Design Group GmbH uploaded patch set 2 V -1 07/08/23, 08:23

  4. core-ci voted on patch set 2 V -1 07/08/23, 08:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43936

  5. JAKOTA Design Group GmbH uploaded patch set 3 V -1 07/08/23, 08:59

  6. core-ci voted on patch set 3 V -1 07/08/23, 09:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43937

  7. JAKOTA Design Group GmbH marked it work in progress 07/08/23, 09:59

  8. JAKOTA Design Group GmbH uploaded patch set 4 V -1 07/08/23, 10:46

  9. core-ci voted on patch set 4 V -1 07/08/23, 10:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43938

  10. JAKOTA Design Group GmbH uploaded patch set 5 V -1 07/08/23, 11:08

  11. core-ci voted on patch set 5 V +1 07/08/23, 11:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43939

  12. JAKOTA Design Group GmbH marked it ready for review 07/08/23, 11:18

  13. JAKOTA Design Group GmbH commented on patch set 5 07/08/23, 11:25

    It seems I f***ed up the connection to the original patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66904 If this is important, I'm sure this can be changed? Also, as there is just the one checkValueForInput function to check all input types for 11.5, I had to get creative to apply the patch without breaking anything else. And only affects int date/time and native date/time fields. Please let me know what you think. Thanks
  14. Benjamin Franzke commented on patch set 5 07/08/23, 14:08

    Reply

    use `git commit --amend` and change the line containing Change-Id to the one of the main-branch patch: Change-Id: I979d59f4abe3dd73117a9e135a74ae3036192d9b then push to the v11 patch again. That will create a new patch on gerrit. Then "Abandon" (button is in the top right corner) this patch, providing the new URL in the message. (we can do that for you, if that description doesn't help) Also adapt the Releases line to contain "main, 12.4, 11.5", not just 11.5, as this patch went into main and 12.4, so we'd document that in there. (ideally, the intention to backport to 11.5 should have been also written on the patch for the main branch, but that's for the next time)
  15. Benjamin Franzke commented on patch set 5 07/08/23, 14:09

    Reply

    > then push to the v11 patch again I meant: then push to the 11.4 branch again
  16. JAKOTA Design Group GmbH commented on patch set 5 07/08/23, 15:07

    Reply

    Thanks, that worked. And you probably meant 11.5 not 11.4?
  17. JAKOTA Design Group GmbH abandoned the change 07/08/23, 15:08