Review main Abandoned

79882[TASK] Clean up tt_content palette field label overrides

Nikita Hovratov CR 0 V 0 Normal +40 −97 updated 07/29/23, 21:14

Commit message

The field label overrides on palette level are mostly unnecessary.
These cases have been cleaned up:

1. override label is identical to standard label -> remove override
   label from translation file.
2. override label is different to standard label and the field is only
   used via the palette -> remove standard label from translation file.
3. Some override labels are defined in Database.xlf -> remove the
   "form_label" version from locallang_ttc.xlf.

Some overrides have been skipped as they seem legitimately specific for
the palette.

The benefit is, when reusing the fields in own content elements and not
using the palettes, the labels are as expected and not an old version
of them.

This is a continuation to #100344 to clean up everything.

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 2

Review log 89

  1. Nikita Hovratov uploaded patch set 1 07/08/23, 19:23

  2. core-ci voted on patch set 1 V +1 07/08/23, 19:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43947

  3. Anja Leichsenring voted on patch set 1 V +1 CR +1 07/11/23, 04:01

  4. Jasmina Ließmann commented on patch set 1 07/11/23, 05:18

    locallang_ttc.xlf:120 Unresolved

    I would rather go with keeping this key instead of using 'colPos_formlabel'.
  5. Georg Ringer commented on patch set 1 CR -1 07/11/23, 05:21

    please keep the labels, at least in the backport but I prefer for main as well
  6. Jasmina Ließmann commented on patch set 1 07/11/23, 05:36

    I'm having trouble with the generalization in the second case. I have always perceived the keys with the suffix "_formlabel" in such a way that they overwrite the field label in individual cases for specific purposes and the original name of the field is the one specified under 'label' => 'LLL:EXT:...". is. If my guess is correct, I would prefer to keep the language keys without "_formlabel" at the original labels (with the values from the "_formlabel" labels as already displayed in the backend). This applies to a large number of keys in locallang_ttc.xl, which are deleted with this patch.
  7. Nikita Hovratov commented on patch set 1 V -1 CR -1 07/11/23, 07:17

    I totally forgot that the labels are also used in the list view. Need to think this through again.
  8. Nikita Hovratov commented on patch set 1 07/11/23, 07:21

    Reply Unresolved

    I just realized that the standard labels are also displayed in other areas of TYPO3 like the list view. In this case an alternative label for FormEngine might be useful. Need to recheck. Maybe just get rid of identical labels at first.
  9. Nikita Hovratov abandoned the change 07/29/23, 21:14

    apparently the alternative labels are needed