79913[BUGFIX] Prevent reaching the placeholder limit in `indexed_search`
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Christian Kuhn +1
- Benni Mack +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1523
-
Stefan Bürk uploaded patch set 1 07/10/23, 05:23
-
core-ci voted on patch set 1 V +1 07/10/23, 05:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43963
-
Stefan Bürk uploaded patch set 2
V +107/10/23, 05:42 -
core-ci voted on patch set 2 V +1 07/10/23, 05:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43964
-
Stefan Bürk updated the commit message in patch set 3
V +107/10/23, 06:25 -
Stefan Bürk updated the commit message in patch set 4 07/10/23, 06:25
-
Stefan Bürk updated the commit message in patch set 5 07/10/23, 06:26
-
core-ci voted on patch set 3 V +1 07/10/23, 06:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43966
-
core-ci voted on patch set 4 V +1 07/10/23, 06:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43967
-
core-ci voted on patch set 5 V +1 07/10/23, 06:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43968
-
Oliver Klee updated the commit message in patch set 6
V +107/10/23, 07:37 -
core-ci voted on patch set 6 V +1 07/10/23, 07:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43970
-
Stefan Bürk rebased onto patch set 7
V +107/11/23, 11:39 -
core-ci voted on patch set 7 V +1 07/11/23, 11:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44035
-
Oliver Klee voted on patch set 7 CR +1 07/11/23, 15:28
-
Stefan Bürk rebased onto patch set 8
CR +1V +107/12/23, 23:10 -
core-ci voted on patch set 8 V +1 07/12/23, 23:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44098
-
Oliver Klee voted on patch set 8 CR +1 07/13/23, 07:27
-
Sybille Peters commented on patch set 8 07/14/23, 08:43
Is there any impact here which users should know about - except fixing the exception ;-) e.g. is it possible to say what will be the impact of load on the system after this change? I assume some queries with many results will now succeed which did not previously (due to exception), resulting in DB queries with possibly long execution time and more load on system. Unfortunately, I have not looked at this extension in a while, so my understanding how it works internally is vague at best. Does not have to be scope of this patch but might make sense to set some hard limits and / or update the documentation. Maybe even to add a changelog. Currently, there is only a very vague "Known Problems" where it is not even clear what (indexing, searching ...?) causes this load / instability that is being taked about and if it still exists and that has been like that a long time. https://docs.typo3.org/c/typo3/cms-indexed-search/main/en-us/KnownProblems/Index.html -
Christian Kuhn voted on patch set 8 V +1 CR +1 07/18/23, 12:43
-
Benni Mack voted on patch set 8 V +1 CR +1 07/18/23, 13:00
-
Stefan Bürk voted on patch set 8 V +2 CR +2 07/18/23, 13:26
-
Stefan Bürk merged patch set 9 07/18/23, 13:26