Review main Merged

79913[BUGFIX] Prevent reaching the placeholder limit in `indexed_search`

Stefan Bürk CR +2 V +2 Easy +4 −11 updated 07/18/23, 13:26

Commit message

The main query execution builds a QueryBuilder instance out of
different sub information. Additionally, several hooks can be
used to influence the created query. On top of this, different
type of search queries are possible.

This change avoid consuming a lot of placeholder for list based
`in()` expressions by using a corresponding QueryBuilder method
suitable for the value type. This means that no placeholder are
used any longer for list expressions.

Note: Max query size may still be exceeded if the lists would
      getting bigger. This can be adjusted by database server
      administrators, but will lead to another exception for
      really large value lists.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1523

  1. Stefan Bürk uploaded patch set 1 07/10/23, 05:23

  2. core-ci voted on patch set 1 V +1 07/10/23, 05:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43963

  3. Stefan Bürk uploaded patch set 2 V +1 07/10/23, 05:42

  4. core-ci voted on patch set 2 V +1 07/10/23, 05:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43964

  5. Stefan Bürk updated the commit message in patch set 3 V +1 07/10/23, 06:25

  6. Stefan Bürk updated the commit message in patch set 4 07/10/23, 06:25

  7. Stefan Bürk updated the commit message in patch set 5 07/10/23, 06:26

  8. core-ci voted on patch set 3 V +1 07/10/23, 06:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43966

  9. core-ci voted on patch set 4 V +1 07/10/23, 06:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43967

  10. core-ci voted on patch set 5 V +1 07/10/23, 06:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43968

  11. Oliver Klee updated the commit message in patch set 6 V +1 07/10/23, 07:37

  12. core-ci voted on patch set 6 V +1 07/10/23, 07:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43970

  13. Stefan Bürk rebased onto patch set 7 V +1 07/11/23, 11:39

  14. core-ci voted on patch set 7 V +1 07/11/23, 11:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44035

  15. Oliver Klee voted on patch set 7 CR +1 07/11/23, 15:28

  16. Stefan Bürk rebased onto patch set 8 CR +1 V +1 07/12/23, 23:10

  17. core-ci voted on patch set 8 V +1 07/12/23, 23:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44098

  18. Oliver Klee voted on patch set 8 CR +1 07/13/23, 07:27

  19. Sybille Peters commented on patch set 8 07/14/23, 08:43

    Is there any impact here which users should know about - except fixing the exception ;-) e.g. is it possible to say what will be the impact of load on the system after this change? I assume some queries with many results will now succeed which did not previously (due to exception), resulting in DB queries with possibly long execution time and more load on system. Unfortunately, I have not looked at this extension in a while, so my understanding how it works internally is vague at best. Does not have to be scope of this patch but might make sense to set some hard limits and / or update the documentation. Maybe even to add a changelog. Currently, there is only a very vague "Known Problems" where it is not even clear what (indexing, searching ...?) causes this load / instability that is being taked about and if it still exists and that has been like that a long time. https://docs.typo3.org/c/typo3/cms-indexed-search/main/en-us/KnownProblems/Index.html
  20. Christian Kuhn voted on patch set 8 V +1 CR +1 07/18/23, 12:43

  21. Benni Mack voted on patch set 8 V +1 CR +1 07/18/23, 13:00

  22. Stefan Bürk voted on patch set 8 V +2 CR +2 07/18/23, 13:26

  23. Stefan Bürk merged patch set 9 07/18/23, 13:26