Review main Merged

79956[TASK] Add more tests for GeneralUtility::isOnCurrentHost

Oliver Klee CR +2 V +2 Easy +13 −2 updated 07/11/23, 09:15

Commit message

There already was a data provider for the negative case of this
method, but no tests using this data provider.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Alexander Schnitzler +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Alexander Schnitzler +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Oliver Klee uploaded patch set 1 07/11/23, 07:31

  2. core-ci voted on patch set 1 V +1 07/11/23, 07:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44007

  3. Alexander Schnitzler commented on patch set 1 07/11/23, 08:19

    GeneralUtilityTest.php:1280

    IIRC, we have a rule of using the `DataProvider` suffix for all data provider methods.
  4. Oli Bartsch voted on patch set 1 V +1 CR +1 07/11/23, 08:22

  5. Oliver Klee commented on patch set 1 07/11/23, 08:51

    GeneralUtilityTest.php:1280 Reply

    Done
  6. Oliver Klee uploaded patch set 2 CR +1 V +1 07/11/23, 08:51

  7. core-ci voted on patch set 2 V +1 07/11/23, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44013

  8. Alexander Schnitzler voted on patch set 2 V +1 CR +1 07/11/23, 09:04

  9. Oli Bartsch voted on patch set 2 V +2 CR +2 07/11/23, 09:15

  10. Oli Bartsch merged patch set 3 07/11/23, 09:15