Review main Merged

79960[BUGFIX] Use correct fallback type for GeneralUtility::sanitizeLocalUrl

Oliver Klee CR +2 V +2 Easy +2 −2 updated 07/11/23, 09:55

Commit message

`GeneralUtility::sanitizeLocalUrl` expects a string. So
the fallback value when calling this method also needs
to be a string, not null. This patch adjusts two of
such calls.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • Alexander Schnitzler +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • Alexander Schnitzler +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 68

  1. Oliver Klee uploaded patch set 1 07/11/23, 08:59

  2. core-ci voted on patch set 1 V +1 07/11/23, 09:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44014

  3. Oli Bartsch uploaded patch set 2 V +1 07/11/23, 09:14

  4. Oli Bartsch voted on patch set 2 V +1 CR +1 07/11/23, 09:14

  5. core-ci voted on patch set 2 V +1 07/11/23, 09:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44017

  6. Alexander Schnitzler voted on patch set 2 V +1 CR +1 07/11/23, 09:34

  7. Stefan Bürk voted on patch set 2 V +2 CR +2 07/11/23, 09:44

  8. Stefan Bürk merged patch set 3 07/11/23, 09:55