79962[!!!][TASK] Make the parameter for GU::sanitizeLocalUrl required
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Alexander Schnitzler +1
-
Verified V +2 Done
- Stefan Bürk +2
- Alexander Schnitzler +1
- core-ci +1 CI
Issues 2
Files 3
Review log 810
-
Oliver Klee uploaded patch set 1 07/11/23, 09:36
-
Alexander Schnitzler voted on patch set 1 V +1 CR +1 07/11/23, 09:41
-
core-ci voted on patch set 1 V +1 07/11/23, 09:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44023
-
Oli Bartsch commented on patch set 1 07/11/23, 09:56
Since we are already breaking here, shouldn't we also add corresponding type declaration?Breaking-101311-MakeParameterForGeneralUtilitySanitizeLocalUrlRequired.rst:27Please add something like "The extension scanner will detect usages as strong match." -
Oliver Klee commented on patch set 1 07/11/23, 10:38
Reply
That's a(nother) can of worms I'd like to tackle in a separate change: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79955 :-)Breaking-101311-MakeParameterForGeneralUtilitySanitizeLocalUrlRequired.rst:27ReplyDone -
Oliver Klee uploaded patch set 2
CR +1V +107/11/23, 10:38 -
core-ci voted on patch set 2 V +1 07/11/23, 10:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44032
-
Alexander Schnitzler voted on patch set 2 V +1 CR +1 07/11/23, 16:34
-
Stefan Bürk voted on patch set 2 V +2 CR +2 07/12/23, 16:22
-
Stefan Bürk merged patch set 3 07/12/23, 16:22