79968[TASK] Modernize array callbacks in EXT:belog and EXT:beuser
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Benni Mack +1
-
Verified V +2 Done
- Stefan Bürk +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/belog/Classes/Domain/Repository/LogEntryRepository.php+1 −1
- typo3/sysext/beuser/Classes/Controller/BackendUserController.php4+1 −1
- typo3/sysext/beuser/Classes/Domain/Repository/BackendUserGroupRepository.php+1 −1
- typo3/sysext/beuser/Classes/Domain/Repository/BackendUserRepository.php+1 −1
- typo3/sysext/beuser/Classes/Domain/Repository/BackendUserSessionRepository.php2+2 −2
Review log 1012
-
Oliver Klee uploaded patch set 1 07/11/23, 12:31
-
core-ci voted on patch set 1 V +1 07/11/23, 12:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44039
-
Stefan Bürk commented on patch set 1 07/11/23, 14:28
-
Oliver Klee commented on patch set 1 07/11/23, 14:37
BackendUserController.php:408ReplyYes, because we have this data flow: 1. `$compareGroupUidList` is `list<string|int>` (which is a subset of `array<int, string|int>`) as it's the result of `array_keys`. 2. `array_flip($compareGroupUidList)` hence is `array<string|int, int>`. (Took me some time to de-know this, too.) -
Benni Mack commented on patch set 1 07/11/23, 16:16
BackendUserSessionRepository.php:76should we also type hint "use (BackendUser $backendUser)"? -
Oliver Klee commented on patch set 1 07/11/23, 16:49
BackendUserSessionRepository.php:76ReplyNo - `use` doesn't allow type declarations, and adding a type declaration leads to a syntax error. (I've just tried it.) -
Oliver Klee commented on patch set 1 07/11/23, 16:54
BackendUserController.php:408Replyde-know -> de-knot :-) -
Oliver Klee rebased onto patch set 2
V +107/12/23, 16:58 -
core-ci voted on patch set 2 V +1 07/12/23, 17:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44089
-
Benni Mack voted on patch set 2 V +1 CR +1 07/12/23, 21:37
-
Stefan Bürk commented on patch set 2 V +2 CR +2 07/12/23, 22:29
BackendUserController.php:408ReplyThanks for clarifing that. -
Stefan Bürk merged patch set 3 07/12/23, 22:29
BackendUserController.php:408