Review 11.5 Merged

79977[BUGFIX] Use correct fallback type for GeneralUtility::sanitizeLocalUrl

Stefan Bürk CR +2 V +2 Easy +2 −2 updated 07/11/23, 09:55

Commit message

`GeneralUtility::sanitizeLocalUrl` expects a string. So
the fallback value when calling this method also needs
to be a string, not null. This patch adjusts two of
such calls.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 57

  1. Stefan Bürk commented on patch set 1 07/11/23, 09:38

    Cherry Picked from branch 12.4. The following files contain Git conflicts: * typo3/sysext/backend/Classes/Controller/LoginController.php
  2. Stefan Bürk uploaded patch set 2 07/11/23, 09:43

  3. Stefan Bürk marked it ready for review 07/11/23, 09:43

  4. core-ci voted on patch set 1 V -1 07/11/23, 09:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44025

  5. core-ci voted on patch set 2 V +1 07/11/23, 09:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44026

  6. Stefan Bürk voted on patch set 2 V +2 CR +2 07/11/23, 09:55

  7. Stefan Bürk merged patch set 3 07/11/23, 09:55