Review main Merged

80003[TASK] Harden array callbacks in EXT:core, part 2

Oliver Klee CR +2 V +2 Normal +30 −30 updated 07/18/23, 12:02

Commit message

Add native type declarations and first-class callables for improved
type safety and readability.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 16

Review log 1320

  1. Oliver Klee uploaded patch set 1 07/11/23, 17:09

  2. Oliver Klee marked it work in progress 07/11/23, 17:14

  3. core-ci voted on patch set 1 V -1 07/11/23, 17:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44057

  4. core-ci commented on patch set 1 07/11/23, 17:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44057

  5. Oliver Klee uploaded patch set 2 V -1 07/11/23, 17:53

  6. Oliver Klee uploaded patch set 3 07/11/23, 17:59

  7. core-ci voted on patch set 2 V -1 07/11/23, 17:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44058

  8. core-ci voted on patch set 3 V +1 07/11/23, 18:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44060

  9. Oliver Klee marked it ready for review 07/11/23, 18:08

  10. Oliver Klee rebased onto patch set 4 V +1 07/12/23, 16:59

  11. core-ci voted on patch set 4 V +1 07/12/23, 17:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44090

  12. Stefan Bürk commented on patch set 4 07/14/23, 10:32

    CompositeExpression.php:55

    This should be `fn (string|self|DoctrineCompositeExpression $value) ...`

    CompositeExpression.php:67

    fn () should also contain `DoctrineCompositeExpression`

    CompositeExpression.php:78

    fn () should also contain `DoctrineCompositeExpression`
  13. Oliver Klee commented on patch set 4 07/14/23, 11:22

    CompositeExpression.php:55 Reply

    This already is included in `self`: ``` class CompositeExpression extends DoctrineCompositeExpression ``` I'll change the `self` to `CompositeExpression` to make this more clear to the reader. Thanks for pointing this out! (I'll update the other two affected places accordingly.)

    CompositeExpression.php:67 Reply

    Done

    CompositeExpression.php:78 Reply

    Done
  14. Oliver Klee uploaded patch set 5 V +1 07/14/23, 11:22

  15. core-ci voted on patch set 5 V +1 07/14/23, 11:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44134

  16. Oliver Klee uploaded patch set 6 V +1 07/14/23, 17:02

  17. Stefan Bürk voted on patch set 6 V +1 CR +1 07/14/23, 17:09

  18. core-ci voted on patch set 6 V +1 07/14/23, 17:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44140

  19. Christian Kuhn voted on patch set 6 V +2 CR +2 07/18/23, 12:02

  20. Christian Kuhn merged patch set 7 07/18/23, 12:02