80003[TASK] Harden array callbacks in EXT:core, part 2
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 16
- typo3/sysext/core/Classes/Console/CommandApplication.php+1 −1
- typo3/sysext/core/Classes/Core/ClassLoadingInformationGenerator.php+1 −1
- typo3/sysext/core/Classes/Country/CountryFilter.php+2 −2
- typo3/sysext/core/Classes/Database/Driver/DriverResult.php+2 −2
- typo3/sysext/core/Classes/Database/Query/Expression/CompositeExpression.php6+3 −3
- typo3/sysext/core/Classes/Database/Query/BulkInsertQuery.php+2 −2
- typo3/sysext/core/Classes/Database/Query/QueryBuilder.php+2 −2
- typo3/sysext/core/Classes/Database/Query/QueryHelper.php+2 −2
- typo3/sysext/core/Classes/Database/Schema/EventListener/SchemaColumnDefinitionListener.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/EventListener/SchemaIndexDefinitionListener.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/TableBuilder.php+3 −3
- typo3/sysext/core/Classes/Database/Schema/Types/EnumType.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/Types/SetType.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/ConnectionMigrator.php+5 −5
- typo3/sysext/core/Classes/Database/Schema/SchemaInformation.php+1 −1
- typo3/sysext/core/Classes/Database/Connection.php+2 −2
Review log 1320
-
Oliver Klee uploaded patch set 1 07/11/23, 17:09
-
Oliver Klee marked it work in progress 07/11/23, 17:14
-
core-ci voted on patch set 1 V -1 07/11/23, 17:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44057
-
core-ci commented on patch set 1 07/11/23, 17:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44057
-
Oliver Klee uploaded patch set 2
V -107/11/23, 17:53 -
Oliver Klee uploaded patch set 3 07/11/23, 17:59
-
core-ci voted on patch set 2 V -1 07/11/23, 17:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44058
-
core-ci voted on patch set 3 V +1 07/11/23, 18:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44060
-
Oliver Klee marked it ready for review 07/11/23, 18:08
-
Oliver Klee rebased onto patch set 4
V +107/12/23, 16:59 -
core-ci voted on patch set 4 V +1 07/12/23, 17:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44090
-
Stefan Bürk commented on patch set 4 07/14/23, 10:32
CompositeExpression.php:67fn () should also contain `DoctrineCompositeExpression`CompositeExpression.php:78fn () should also contain `DoctrineCompositeExpression` -
Oliver Klee commented on patch set 4 07/14/23, 11:22
CompositeExpression.php:55ReplyThis already is included in `self`: ``` class CompositeExpression extends DoctrineCompositeExpression ``` I'll change the `self` to `CompositeExpression` to make this more clear to the reader. Thanks for pointing this out! (I'll update the other two affected places accordingly.)CompositeExpression.php:67ReplyDoneCompositeExpression.php:78ReplyDone -
Oliver Klee uploaded patch set 5
V +107/14/23, 11:22 -
core-ci voted on patch set 5 V +1 07/14/23, 11:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44134
-
Oliver Klee uploaded patch set 6
V +107/14/23, 17:02 -
Stefan Bürk voted on patch set 6 V +1 CR +1 07/14/23, 17:09
-
core-ci voted on patch set 6 V +1 07/14/23, 17:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44140
-
Christian Kuhn voted on patch set 6 V +2 CR +2 07/18/23, 12:02
-
Christian Kuhn merged patch set 7 07/18/23, 12:02
CompositeExpression.php:55