Review main Merged

80005[TASK] Replace deprecated egrep in commit-msg hook

Benjamin Franzke CR +2 V +2 Easy +4 −4 updated 07/12/23, 07:30

Commit message

egrep is deprecated since 2.5.3 (2007) and is
marked as obsolete in grep 3.8, see
https://lists.gnu.org/archive/html/info-gnu/2022-09/msg00001.html

Also remove a stray \ before the # symbol,
which doesn't need escaping in grep.

Prevents the following warnings during the
commit-msg hook:

  egrep: warning: egrep is obsolescent; using grep -E
  egrep: warning: egrep is obsolescent; using grep -E
  egrep: warning: egrep is obsolescent; using grep -E
  grep: warning: stray \ before #
  egrep: warning: egrep is obsolescent; using grep -E

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Alexander Schnitzler +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Alexander Schnitzler +1
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 78

  1. Benjamin Franzke uploaded patch set 1 07/12/23, 04:16

  2. Benjamin Franzke commented on patch set 1 07/12/23, 04:21

    Let me know if there are mac/windows users, that use some custom grep, where grep -E is unavailble. In that case we'd simply rewrite the regexes to basic instead of extended regexes.
  3. core-ci voted on patch set 1 V +1 07/12/23, 04:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44066

  4. Benni Mack voted on patch set 1 V +1 CR +1 07/12/23, 06:47

  5. Alexander Schnitzler commented on patch set 1 V +1 CR +1 07/12/23, 07:25

    Thanks!
  6. Andreas Kienast voted on patch set 1 V +1 CR +1 07/12/23, 07:28

  7. Benjamin Franzke commented on patch set 1 V +2 CR +2 07/12/23, 07:30

    also tested on a mac now, will merge.
  8. Benjamin Franzke merged patch set 2 07/12/23, 07:30