80005[TASK] Replace deprecated egrep in commit-msg hook
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Alexander Schnitzler +1
- Andreas Kienast +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Alexander Schnitzler +1
- Andreas Kienast +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 1
Review log 78
-
Benjamin Franzke uploaded patch set 1 07/12/23, 04:16
-
Benjamin Franzke commented on patch set 1 07/12/23, 04:21
Let me know if there are mac/windows users, that use some custom grep, where grep -E is unavailble. In that case we'd simply rewrite the regexes to basic instead of extended regexes. -
core-ci voted on patch set 1 V +1 07/12/23, 04:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44066
-
Benni Mack voted on patch set 1 V +1 CR +1 07/12/23, 06:47
-
Alexander Schnitzler commented on patch set 1 V +1 CR +1 07/12/23, 07:25
Thanks! -
Andreas Kienast voted on patch set 1 V +1 CR +1 07/12/23, 07:28
-
Benjamin Franzke commented on patch set 1 V +2 CR +2 07/12/23, 07:30
also tested on a mac now, will merge. -
Benjamin Franzke merged patch set 2 07/12/23, 07:30