Review main Merged

80006[BUGFIX] Prevent default behavior only for page selector links

Andreas Kienast CR +2 V +2 Easy +1 −1 updated 07/12/23, 08:37

Commit message

The change for #101271 introduced a global event handler to replace the
inline onclick events. The current approach breaks all links on the page
once paging is available as the default click behavior is disabled too
early.

This patch now applies `preventDefault()` only if the clicked link is an
actual `.tx-indexedsearch-page-selector` element.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 78

  1. Andreas Kienast uploaded patch set 1 07/12/23, 07:17

  2. core-ci voted on patch set 1 V +1 07/12/23, 07:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44067

  3. Oli Bartsch voted on patch set 1 V +1 CR +1 07/12/23, 07:30

  4. Benjamin Franzke voted on patch set 1 CR +1 07/12/23, 07:32

  5. Oliver Hader voted on patch set 1 CR +1 07/12/23, 07:52

  6. Benjamin Franzke voted on patch set 1 V +2 CR +2 07/12/23, 08:26

  7. Benjamin Franzke merged patch set 2 07/12/23, 08:26

  8. Stefan Bürk commented on patch set 2 07/12/23, 08:37

    post +1/+1 ... internet disconnected after reviewing and testing before I could vote.