Review main Merged

80008[BUGFIX] Use Symfony filesystem in `InstallerScripts`

Andreas Kienast CR +2 V +2 Easy +6 −9 updated 07/12/23, 08:31

Commit message

The internal script `Build/Scripts/composer/InstallerScripts.php`
references the `TYPO3\CMS\Composer\Plugin\Util\Filesystem` that doesn't
exist anymore. Since Symfony is used anyway, all former usages of
`Util\Filesystem` are migrated to Symfony now.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Andreas Kienast uploaded patch set 1 07/12/23, 07:42

  2. Andreas Kienast uploaded patch set 2 07/12/23, 07:44

  3. core-ci voted on patch set 1 V +1 07/12/23, 07:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44071

  4. core-ci voted on patch set 2 V +1 07/12/23, 07:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44072

  5. Stefan Bürk voted on patch set 2 V +1 CR +1 07/12/23, 07:53

  6. Benjamin Franzke voted on patch set 2 CR +1 07/12/23, 08:03

  7. Benjamin Franzke voted on patch set 2 V +2 CR +2 07/12/23, 08:31

  8. Benjamin Franzke merged patch set 3 07/12/23, 08:31