80012[BUGFIX] Localize children of all languages element
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Benni Mack +1
-
Verified V +2 Done
- Stefan Bürk +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 22
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMapper.php+5 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/parent_child_translation/Classes/Controller/MainController.php4new+36 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/parent_child_translation/Classes/Domain/Model/Child.php6new+44 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/parent_child_translation/Classes/Domain/Model/Main.php14new+135 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/parent_child_translation/Classes/Domain/Model/Squeeze.php12new+65 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/parent_child_translation/Classes/Domain/Repository/MainRepository.phpnew+43 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/parent_child_translation/Configuration/TCA/Overrides/sys_template.php2new+7 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/parent_child_translation/Configuration/TCA/Overrides/tt_content.php2new+11 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/parent_child_translation/Configuration/TCA/tx_parentchildtranslation_domain_model_child.phpnew+72 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/parent_child_translation/Configuration/TCA/tx_parentchildtranslation_domain_model_main.phpnew+97 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/parent_child_translation/Configuration/TCA/tx_parentchildtranslation_domain_model_squeeze.phpnew+90 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/parent_child_translation/Configuration/TypoScript/constants.typoscriptnew+10 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/parent_child_translation/Configuration/TypoScript/setup.typoscriptnew+10 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/parent_child_translation/Configuration/Services.yamlnew+9 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/parent_child_translation/Resources/Private/Templates/List.htmlnew+20 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/parent_child_translation/composer.jsonnew+19 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/parent_child_translation/ext_emconf.phpnew+21 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/parent_child_translation/ext_localconf.php2new+18 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/parent_child_translation/ext_tables.sql2new+24 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/parentChildTranslationExampleData.csvnew+24 −0
Review log 2942
Show 1117 earlier messages
-
André Buchmann uploaded patch set 1 07/12/23, 13:32
-
André Buchmann uploaded patch set 2 07/12/23, 13:37
-
core-ci voted on patch set 1 V -1 07/12/23, 13:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44080
-
core-ci voted on patch set 2 V -1 07/12/23, 13:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44082
-
André Buchmann uploaded patch set 3
V -107/12/23, 14:01 -
core-ci voted on patch set 3 V +1 07/12/23, 14:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44083
-
Oliver Klee commented on patch set 3 07/12/23, 14:47
Can we please cover this with a regression test (a functional test)? -
Oliver Klee commented on patch set 3 07/12/23, 15:02
Reply
(marking this comment as not resolved yet) -
André Buchmann uploaded patch set 4
V +107/28/23, 12:55 -
core-ci voted on patch set 4 V -1 07/28/23, 13:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44673
-
André Buchmann marked it work in progress 07/28/23, 13:33
-
André Buchmann uploaded patch set 5
V -107/28/23, 14:25 -
core-ci voted on patch set 5 V -1 07/28/23, 14:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44677
-
André Buchmann uploaded patch set 6
V -107/29/23, 10:49 -
André Buchmann uploaded patch set 7 07/29/23, 10:52
-
core-ci voted on patch set 6 V -1 07/29/23, 10:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44730
-
André Buchmann uploaded patch set 8 07/29/23, 10:58
-
core-ci voted on patch set 7 V -1 07/29/23, 11:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44731
-
André Buchmann uploaded patch set 9 07/29/23, 11:05
-
core-ci voted on patch set 8 V -1 07/29/23, 11:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44732
-
core-ci voted on patch set 9 V +1 07/29/23, 11:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44733
-
André Buchmann marked it ready for review 07/29/23, 11:13
-
André Buchmann commented on patch set 9 07/29/23, 11:14
Reply
Tests are now implemented -
Stefan Bürk commented on patch set 9 07/29/23, 14:41
ParentChildTranslation.php:26Should be "ParentChildTranslationTest". We use a `Test` suffix for tests, which is a casual practice for unit/functional tests. -
André Buchmann uploaded patch set 10
V +107/30/23, 09:15 -
core-ci voted on patch set 10 V -1 07/30/23, 09:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44746
-
André Buchmann commented on patch set 10 07/30/23, 09:32
ParentChildTranslation.php:26ReplySorry, missed that. Is now fixed. -
core-ci commented on patch set 10 07/30/23, 10:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44746
-
Stefan Bürk commented on patch set 10 07/30/23, 12:01
ParentChildTranslation.php:26ReplyNow the test is executed in CI and failing for postgres. -
André Buchmann uploaded patch set 11
V -107/31/23, 08:01 -
Benni Mack commented on patch set 11 07/31/23, 08:04
very nice work!!! -
core-ci voted on patch set 11 V +1 07/31/23, 08:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44779
-
anonymized-98012 voted on patch set 11 CR +1 08/31/23, 07:21
-
anonymized-98012 voted on patch set 11 V +1 09/01/23, 07:41
-
Oliver Klee voted on patch set 11 V +1 09/01/23, 10:34
-
Stefan Bürk commented on patch set 11 09/05/23, 13:32
Nice work. Found some minor things. TBH - did not gasp this in the first run. Need to play around more with it and have a relook - and think about further implications. Not sure if the tests are "sufficient" enough. I have a feeling that we oversee forther things, but I might be wrong. Will take a relook the next days.MainController.php:24test controller, no need for extending. make final.MainController.php:28We can use ccp here (with readonly). V11 support can change this than to this variant.Child.php:27Is this not superfluous with the native property type ?Child.php:34return type is superfluous.Child.php:44Param type is superfluous.Main.php:30superfluous ?Main.php:37superfluousMain.php:85superfluousMain.php:95superfluousMain.php:105superfluousMain.php:115superfluousMain.php:125superfluous - the comment is nearly useless, and the method/variable name makes it obiousSqueeze.php:27superfluousSqueeze.php:34superfluousSqueeze.php:41superfluousSqueeze.php:51superfluousSqueeze.php:61superfluousSqueeze.php:71superfluoussys_template.php:5CORE usually uses ``` defined('TYPO3') or die(); ``` which is also the "recommended" snippet communicated. We should keep that and not starting mixing it in the core / fixture extensions.tt_content.php:5``` defined('TYPO3') or die(); ```ext_localconf.php:6``` defined('TYPO3') or die(); ```ext_tables.sql:1Core way is to have comment lines per create-table set. We should keep that for fixture extensions also (as best-practice). ``` # # Table structure for table 'tx_parentchildtranslation_domain_model_main' # ``` same for other tables in this file ...ParentChildTranslationTest.php:38Only needed two times .. avoid the property and this in the setUp method, and instead use it directly in the test functions below. Remove this along with the property in L30. Avoiding state in test classes if possible.ParentChildTranslationTest.php:46Avoid the property and call directly: ``` $this->get(MainRepository::class)->createQuery(); ```ParentChildTranslationTest.php:73Avoid the property and call directly: ``` $this->get(MainRepository::class)->createQuery(); ``` -
André Buchmann uploaded patch set 12
CR +1V +109/05/23, 14:20 -
core-ci voted on patch set 12 V +1 09/05/23, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46241
-
André Buchmann commented on patch set 12 09/05/23, 14:50
Reply
Thanks for the review. I've added the proposed code changes. Let me know if you find more test cases.MainController.php:24ReplyClass is now finalMainController.php:28Replyused readonly. Wasn't sure if I should do this due to php compatibilityChild.php:27ReplyI think so. RemovedChild.php:34ReplyRemovedChild.php:44ReplyRemovedMain.php:30ReplyRemovedMain.php:37ReplyRemovedMain.php:85ReplyRemovedMain.php:95ReplyRemovedMain.php:105ReplyRemovedMain.php:115ReplyRemovedMain.php:125ReplyRemovedSqueeze.php:27ReplyRemovedSqueeze.php:34ReplyRemovedSqueeze.php:41ReplyRemovedSqueeze.php:51ReplyRemovedSqueeze.php:61ReplyRemovedSqueeze.php:71ReplyRemovedsys_template.php:5ReplyI agree. It's changed.tt_content.php:5ReplyChangedext_localconf.php:6ReplyChangedext_tables.sql:1ReplyAdded comment for each tableParentChildTranslationTest.php:38ReplyThanks for the hint to improve the logic. It's removed with L30ParentChildTranslationTest.php:46ReplyChangedParentChildTranslationTest.php:73ReplyChanged -
Benni Mack voted on patch set 12 V +1 CR +1 09/08/23, 20:13
-
Stefan Bürk voted on patch set 12 V +2 CR +2 09/08/23, 21:03
-
Stefan Bürk merged patch set 13 09/08/23, 21:54