Review main Merged

80017[BUGFIX] Handle unavailability of (dis)allowed extensions in FileBrowser

Andreas Kienast CR +2 V +2 Easy +3 −4 updated 07/14/23, 09:40

Commit message

For cases when the FileBrowser doesn't receive any information
of allowed or disallowed file extensions via the "bparams" query
parameter, the code is slightly adjusted to handle this case
to avoid PHP errors.

Additonally, the avatar field of the user settings is adjusted
to provide corresponding information, while the allowed types
are set to the "imagefile_ext" list. Previously used "allowed"
option in the configuration of the field is removed as it had
no effect. The avatar image is always checked against the
"imagefile_ext" list.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 1013

  1. Andreas Kienast uploaded patch set 1 07/13/23, 07:30

  2. Andreas Kienast uploaded patch set 2 07/13/23, 07:31

  3. core-ci voted on patch set 1 V -1 07/13/23, 07:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44107

  4. core-ci voted on patch set 2 V +1 07/13/23, 07:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44108

  5. Oli Bartsch uploaded patch set 3 V +1 07/13/23, 07:57

  6. Oli Bartsch voted on patch set 3 V +1 CR +1 07/13/23, 07:59

  7. core-ci voted on patch set 3 V +1 07/13/23, 08:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44112

  8. Oliver Klee commented on patch set 3 07/13/23, 08:08

    Is 11.5 also affected, i.e., could the PHP errors also occur in 11.5?
  9. Oli Bartsch commented on patch set 3 07/13/23, 09:38

    Reply

    No, this was introduced with #101231.
  10. Stefan Bürk voted on patch set 3 CR +1 07/14/23, 09:12

  11. Benni Mack voted on patch set 3 V +1 CR +1 07/14/23, 09:38

  12. Andreas Kienast voted on patch set 3 V +2 CR +2 07/14/23, 09:40

  13. Andreas Kienast merged patch set 4 07/14/23, 09:40