80019[TASK] Ensure TypoScript traversers are stateless
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 20
- typo3/sysext/backend/Classes/Controller/PageTsConfig/PageTsConfigActiveController.php+9 −13
- typo3/sysext/backend/Classes/Controller/PageTsConfig/PageTsConfigIncludesController.php+11 −12
- typo3/sysext/core/Classes/TypoScript/AST/Traverser/AstTraverser.php+18 −22
- typo3/sysext/core/Classes/TypoScript/IncludeTree/Traverser/ConditionVerdictAwareIncludeTreeTraverser.php+14 −24
- typo3/sysext/core/Classes/TypoScript/IncludeTree/Traverser/IncludeTreeTraverser.php+14 −24
- typo3/sysext/core/Classes/TypoScript/IncludeTree/Traverser/IncludeTreeTraverserInterface.php+4 −5
- typo3/sysext/core/Classes/TypoScript/PageTsConfigFactory.php+6 −8
- typo3/sysext/core/Classes/TypoScript/TypoScriptStringFactory.php+1 −2
- typo3/sysext/core/Classes/TypoScript/UserTsConfigFactory.php+4 −3
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/SysTemplateTreeBuilderTest.php+1 −2
- typo3/sysext/core/Tests/Unit/TypoScript/AST/Traverser/AstTraverserTest.phpnew+36 −0
- typo3/sysext/core/Tests/Unit/TypoScript/IncludeTree/Traverser/ConditionVerdictAwareIncludeTreeTraverserTest.phpnew+36 −0
- typo3/sysext/core/Tests/Unit/TypoScript/IncludeTree/Traverser/IncludeTreeTraverserTest.phpnew+36 −0
- typo3/sysext/extbase/Classes/Configuration/BackendConfigurationManager.php+9 −9
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+23 −23
- typo3/sysext/install/Classes/Controller/SettingsController.php+1 −3
- typo3/sysext/t3editor/Classes/Controller/CodeCompletionController.php+1 −2
- typo3/sysext/tstemplate/Classes/Controller/ActiveTypoScriptController.php+25 −25
- typo3/sysext/tstemplate/Classes/Controller/ConstantEditorController.php+4 −12
- typo3/sysext/tstemplate/Classes/Controller/TemplateAnalyzerController.php+16 −24
Review log 1623
-
Christian Kuhn uploaded patch set 1 07/13/23, 11:20
-
core-ci voted on patch set 1 V -1 07/13/23, 11:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44118
-
Christian Kuhn uploaded patch set 2
V -107/13/23, 11:56 -
Christian Kuhn uploaded patch set 3 07/13/23, 12:04
-
core-ci voted on patch set 2 V -1 07/13/23, 12:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44119
-
core-ci voted on patch set 3 V +1 07/13/23, 12:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44120
-
Christian Kuhn uploaded patch set 4
V +107/16/23, 09:49 -
core-ci voted on patch set 4 V +1 07/16/23, 09:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44191
-
Oliver Klee commented on patch set 4 07/16/23, 10:33
I'd prefer to use the commit message to describe what the commit changes. What do you think of one of these lines? - Make the TypoScript traversers stateless - Allow the TypoScript traversers to be stateless - Ensure that the TypoScript traversers are stateless -
Stefan Bürk updated the commit message in patch set 5
V +107/17/23, 04:59 -
Stefan Bürk commented on patch set 5 07/17/23, 04:59
Reply
Done -
core-ci voted on patch set 5 V +1 07/17/23, 05:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44197
-
Stefan Bürk voted on patch set 5 CR +1 07/17/23, 05:19
-
Christian Kuhn updated the commit message in patch set 6
CR +1V +107/17/23, 08:25 -
Christian Kuhn updated the commit message in patch set 7 07/17/23, 08:25
-
core-ci voted on patch set 7 V +1 07/17/23, 08:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44201
-
core-ci voted on patch set 6 V +1 07/17/23, 08:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44200
-
Benni Mack commented on patch set 7 CR +1 07/17/23, 10:26
looks good on reading. -
Benni Mack voted on patch set 7 V +1 07/17/23, 10:32
-
Stefan Bürk voted on patch set 7 V +1 CR +1 07/17/23, 10:40
-
Stefan Bürk commented on patch set 7 07/17/23, 10:42
Looks good, and could not find any overseen traversers. Tested different scenarious and could not find issues with this change. Nice work to make them stateless. -
Christian Kuhn voted on patch set 7 V +2 CR +2 07/17/23, 11:04
-
Christian Kuhn merged patch set 8 07/17/23, 11:04