Review main Merged

80019[TASK] Ensure TypoScript traversers are stateless

Christian Kuhn CR +2 V +2 Hard +269 −213 updated 07/17/23, 11:04

Commit message

The TypoScript traverser service classes should be
stateless: They currently have a visitor property
plus addVisitor() and resetVisitors() methods.

The patch refacorts the traversers by handing the
list of visitors directly to traverse() and avoids
service class state this way.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 20

Review log 1623

  1. Christian Kuhn uploaded patch set 1 07/13/23, 11:20

  2. core-ci voted on patch set 1 V -1 07/13/23, 11:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44118

  3. Christian Kuhn uploaded patch set 2 V -1 07/13/23, 11:56

  4. Christian Kuhn uploaded patch set 3 07/13/23, 12:04

  5. core-ci voted on patch set 2 V -1 07/13/23, 12:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44119

  6. core-ci voted on patch set 3 V +1 07/13/23, 12:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44120

  7. Christian Kuhn uploaded patch set 4 V +1 07/16/23, 09:49

  8. core-ci voted on patch set 4 V +1 07/16/23, 09:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44191

  9. Oliver Klee commented on patch set 4 07/16/23, 10:33

    I'd prefer to use the commit message to describe what the commit changes. What do you think of one of these lines? - Make the TypoScript traversers stateless - Allow the TypoScript traversers to be stateless - Ensure that the TypoScript traversers are stateless
  10. Stefan Bürk updated the commit message in patch set 5 V +1 07/17/23, 04:59

  11. Stefan Bürk commented on patch set 5 07/17/23, 04:59

    Reply

    Done
  12. core-ci voted on patch set 5 V +1 07/17/23, 05:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44197

  13. Stefan Bürk voted on patch set 5 CR +1 07/17/23, 05:19

  14. Christian Kuhn updated the commit message in patch set 6 CR +1 V +1 07/17/23, 08:25

  15. Christian Kuhn updated the commit message in patch set 7 07/17/23, 08:25

  16. core-ci voted on patch set 7 V +1 07/17/23, 08:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44201

  17. core-ci voted on patch set 6 V +1 07/17/23, 08:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44200

  18. Benni Mack commented on patch set 7 CR +1 07/17/23, 10:26

    looks good on reading.
  19. Benni Mack voted on patch set 7 V +1 07/17/23, 10:32

  20. Stefan Bürk voted on patch set 7 V +1 CR +1 07/17/23, 10:40

  21. Stefan Bürk commented on patch set 7 07/17/23, 10:42

    Looks good, and could not find any overseen traversers. Tested different scenarious and could not find issues with this change. Nice work to make them stateless.
  22. Christian Kuhn voted on patch set 7 V +2 CR +2 07/17/23, 11:04

  23. Christian Kuhn merged patch set 8 07/17/23, 11:04