Review main Merged

80021[BUGFIX] Use 12/24 hour format in date picker depending on client

Andreas Kienast CR +2 V +2 Easy +2 −1 updated 07/17/23, 06:53

Commit message

flatpicker uses the 12 hours format by default, offering an AM/PM
selector next to the time dropdowns. In some regions, using this setting
is rather unusual and may lead to user errors.

To relax the sitation, browser API is used to determine the time format
based on the client's language. Unfortunately, it seems browsers always
assume the format based on the language only and ignore potentially
overridden settings in the operating system.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • Torben Hansen +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Torben Hansen +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 810

  1. Andreas Kienast uploaded patch set 1 07/14/23, 06:18

  2. Andreas Kienast uploaded patch set 2 07/14/23, 06:19

  3. core-ci voted on patch set 1 V +1 07/14/23, 06:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44127

  4. core-ci voted on patch set 2 V +1 07/14/23, 06:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44128

  5. Benni Mack commented on patch set 2 CR +1 07/14/23, 07:38

    nice one!
  6. Oliver Klee voted on patch set 2 CR +1 07/14/23, 07:46

  7. Stefan Bürk commented on patch set 2 V +1 CR +1 07/14/23, 17:47

    Really nice. I guess, it make at lease more sense for DACH people. Maybe we can think of a user setting to influence this, and using the browser api as fallback (feature v13) - you are more into it to tell if this may make sense or not. But unrelated to this change.
  8. Torben Hansen voted on patch set 2 V +1 CR +1 07/16/23, 05:11

  9. Benjamin Franzke voted on patch set 2 V +2 CR +2 07/17/23, 06:53

  10. Benjamin Franzke merged patch set 3 07/17/23, 06:53