Review main Merged

80025[BUGFIX] Avoid exception in presets of Install Tool

Georg Ringer CR +2 V +2 Easy +3 −3 updated 07/14/23, 20:32

Commit message

The method str_contains requires the 1st argument to be a string.
So we need to ensure that it is a string.

(It can be `null` if the command ran into an error.)

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1518

  1. Georg Ringer uploaded patch set 1 07/14/23, 12:25

  2. Georg Ringer commented on patch set 1 07/14/23, 12:25

    This change is ready for review.
  3. Oli Bartsch commented on patch set 1 07/14/23, 12:29

    Please add related issue #70869

    ImageMagick6Preset.php:85

    Please add the typecast in line 83, like done in GraphicsMagickPreset
  4. Andreas Kienast commented on patch set 1 07/14/23, 12:30

    ImageMagick6Preset.php:85 Reply

    I wonder why this is null at all. Did the execution of `$command` fail?
  5. core-ci voted on patch set 1 V +1 07/14/23, 12:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44136

  6. Benni Mack updated the commit message in patch set 2 V +1 07/14/23, 12:36

  7. core-ci voted on patch set 2 V +1 07/14/23, 12:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44137

  8. Oliver Klee commented on patch set 2 07/14/23, 12:52

    I propose having this in 11.5 as well (even if the change that triggered this was only merged in main and 12.4) so 11.5 is one step safer with PHP 8.1.
  9. Oliver Klee voted on patch set 2 CR +1 07/14/23, 13:50

  10. Oliver Klee commented on patch set 2 07/14/23, 14:58

    Reply

    Done
  11. Oliver Klee commented on patch set 2 CR -1 07/14/23, 17:10

    On it …

    ImageMagick6Preset.php:85 Reply

    I think an `is_string` check would make it more obvious that the first line is missing (instead of being an empty string).
  12. Oliver Klee uploaded patch set 3 CR -1 V +1 07/14/23, 17:13

  13. Oliver Klee commented on patch set 2 CR -1 07/14/23, 17:13

    Reply

    Done

    ImageMagick6Preset.php:85 Reply

    Done
  14. Oliver Klee voted on patch set 3 CR +1 07/14/23, 17:13

  15. core-ci voted on patch set 3 V +1 07/14/23, 17:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44143

  16. Stefan Bürk voted on patch set 3 V +1 CR +1 07/14/23, 17:37

  17. Oli Bartsch voted on patch set 3 V +2 CR +2 07/14/23, 20:32

  18. Oli Bartsch merged patch set 4 07/14/23, 20:32